feat: Add support for publishing packages from GitHub organizations#138
feat: Add support for publishing packages from GitHub organizations#138meiseayoung wants to merge 5 commits into
Conversation
- Add UserOrganization entity to store user's org memberships - Fetch user's organizations during OAuth login via GitHub API - Modify check_vcs() to accept URLs from user's organizations - Automatically use organization name as package prefix when publishing from org repos This allows users who are members of GitHub organizations to publish packages from organization repositories. The package name will use the organization name as prefix (e.g., 'v-hono.hono' instead of 'meiseayoung.hono' when publishing from v-hono organization). Closes #XXX
- Add tests for extract_owner_from_url function - Add tests for check_vcs backward compatibility - Add tests for check_vcs_with_orgs new functionality - Add tests for is_valid_mod_name validation - Add tests for UserOrganization entity and membership logic All 2 test files pass with 20+ test cases covering: - Own account publishing (existing behavior) - Organization member publishing (new feature) - Non-member organization rejection - Admin bypass - Edge cases and error handling
|
If you run |
got it,thank you. |
|
@codex review |
Review:
|
Summary
This PR adds support for publishing packages from GitHub organization repositories. Currently, VPM only allows users to publish packages from their personal GitHub accounts. This change enables users who are members of GitHub organizations to publish packages from organization repositories.
Problem
When a user (e.g.,
meiseayoung) is a member of a GitHub organization (e.g.,v-hono) and wants to publish packages from organization repositories, they receive the error: "You must submit a package from your own account".Solution
Fetch user's organizations during OAuth login - When a user logs in via GitHub OAuth, we now fetch their organization memberships using the GitHub API (
/user/orgs)Store organization memberships - Organizations are stored in a new
UserOrganizationtableValidate against organizations - When creating a package, the URL is validated against both the user's account AND their organizations
Use organization as package prefix - If the URL belongs to an organization, the package name uses the org name as prefix (e.g.,
v-hono.honoinstead ofmeiseayoung.hono)Changes
src/entity/organization.vsrc/repo/organization.vsrc/auth.vsrc/usecase/package/packages.vsrc/package.vsrc/usecase/package/packages_test.vsrc/repo/organization_test.vDatabase Migration