feat: fire OnScrollback hook for lines scrolled off the main screen#6
Open
leogr wants to merge 1 commit into
Open
feat: fire OnScrollback hook for lines scrolled off the main screen#6leogr wants to merge 1 commit into
leogr wants to merge 1 commit into
Conversation
Owner
|
Woops, just needs a rebase now that #5 is merged. (Thanks!) |
76e37cf to
e1db390
Compare
Contributor
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnScrollback is already public and documented ("called every time a line is about to be pushed out of the visible screen region"), but the implementation in scrollUpN is a no-op - the call was commented out, so setting the hook does nothing today.
This PR wires it up: when the main screen scrolls a line off the top, the hook fires with that line (content + per-cell format).
A few details:
I also tightened the doc to match this contract - including that the hook runs synchronously during input and shouldn't re-enter the terminal.