feat: 통화(Currency) 도메인 API 및 외부 환율 연동 배치 구현 (#50)#52
Open
hyun7586 wants to merge 1 commit into
Open
Conversation
- Currency, ExchangeRateHistory 엔티티 및 Repository 구현 - 프레젠테이션 계층 DTO (CurrencySummary, Detail 등) 작성 - 외부 API 통신용 RestTemplateConfig 및 CurrencySyncService 스케줄러 구축 - 검색, 단건, 히스토리, 추천 API 엔드포인트를 제공하는 CurrencyController 연동 - BusinessErrorCode의 BRANCH_NOT_FOUND 중복 선언 버그 픽스
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Type of Change
Change Summary
Currency,ExchangeRateHistory핵심 도메인 Entity와 Repository 인터페이스를 구현했습니다.CurrencyController와 관련 클라이언트 응답용 DTO를 작성했습니다.@Scheduled배치 서비스(CurrencySyncService)를 구축했습니다.Decisions
Currency테이블을 단일 통화 코드 기준(암묵적 KRW Base)으로 설계했습니다. (GitHub Discussion 참고)BusinessErrorCode내에 중복 선언되어 컴파일 에러를 유발하던BRANCH_NOT_FOUND(C106) 코드를 제거했습니다.Review Points
CurrencySyncService의 매일 자정 스케줄러가 외부 환율 API를 호출할 때 타임아웃(5초)이나 실패 시 기존 데이터를 안전하게 롤백/유지하는지 중점적으로 리뷰해 주시면 좋겠습니다.@PublicApi어노테이션을 부착해 두었습니다.