-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(cmcd): upgrade to CMCD v2 using @svta/cml-cmcd CmcdReporter #7725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
littlespex
wants to merge
26
commits into
video-dev:master
Choose a base branch
from
littlespex:issue/7723-cmcd-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6d0377b
Migrate CMCD from @svta/common-media-library to @svta/cml-cmcd and ad…
claude 17be620
Add CMCD v2 data fields and CmcdReporter event-mode reporting
claude 72b69d0
Export CMCD v2 types and add comprehensive test coverage
claude db011bc
fix: remove @svta/common-media-library
littlespex 5f83511
feat: update cmcd-controller to use CML's CmcdReporter
littlespex a0ff463
Merge branch 'master' into issue/7723-cmcd-v2
littlespex ba31f04
chore: update CML packages
littlespex b65b1e0
fix: build system cleanup
littlespex 8c5f8ca
fix: export clean up
littlespex cf201b6
fix: api-extractor rebuild
littlespex 214bcbb
revert: build config change
littlespex 1fd0cdc
Merge branch 'master' into issue/7723-cmcd-v2
littlespex f949091
Merge branch 'master' into issue/7723-cmcd-v2
littlespex 62203b6
fix: address code review comment about muxed buffers
littlespex 66c92dd
feat(cmcd): route event report requests through xhrSetup/fetchSetup h…
littlespex 4ef9d6d
Merge branch 'master' into issue/7723-cmcd-v2
littlespex aa08b0e
feat(cmcd): add CMCD v2 e2e tests and upgrade @svta/cml-cmcd to 2.2.0
littlespex a85caae
Merge branch 'master' into issue/7723-cmcd-v2
littlespex f2e021e
fix: return 204 for event mode responses
littlespex 2cc2d75
refactor(cmcd): use CmcdReporter default requester, add loader config…
littlespex 1ef698a
chore: update api file
littlespex 2c7cab3
Merge branch 'master' into issue/7723-cmcd-v2
littlespex a35400d
Merge branch 'master' into issue/7723-cmcd-v2
littlespex c148687
chore: update CMCD package for revision B changes
littlespex f06bd8d
Merge branch 'master' into issue/7723-cmcd-v2
littlespex c10b1f5
fix(cmcd): address review feedback on controller, tests, and docs
littlespex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add these new options to docs/API.md#cmcd?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in c10b1f5, added
version,eventTargets(with a child list coveringurl,events,interval,batchSize, and per-targetincludeKeys), andloaderto the CMCD section indocs/API.md. Also extended the existingincludeKeysline to note the version-aware default.