Skip to content

docs(live-verify): fold in #637-#668, correct the entries the merge burst falsified - #672

Merged
vibechoom merged 1 commit into
mainfrom
docs/live-verify-fold-637-668
Jul 31, 2026
Merged

docs(live-verify): fold in #637-#668, correct the entries the merge burst falsified#672
vibechoom merged 1 commit into
mainfrom
docs/live-verify-fold-637-668

Conversation

@vibechoom

Copy link
Copy Markdown
Contributor

Closes #660

Scope

#660 was filed when the doc's coverage stopped at #634, expecting only #637/#639/#642 to fold in. Seven more PRs merged in the meantime, so this pass covers all ten: #637, #639, #642, #644, #645, #662, #663, #664, #666, #668.

The correction #660 asked for

The #630 entry told a verifier that modal::close_all tears down with window.close(). #637 changed that call to window.destroy() after #630 had already merged, so the entry named a call the code no longer makes — confirmed against the current modal.rs:1019 (panel.window.destroy();). Corrected the entry and added a note explaining the timeline (the entry was true when written, false the moment #637 landed).

Other falsified-expectation sweep

Per the task, I looked for other entries the merge burst falsified, particularly around the networkd startup path (#645 changed it from "go inert forever" to "retry unboundedly"). Found no existing entry describing the pre-#645 networkd startup-inertia behavior — it was never previously documented — so this is purely additive: added a new #645 bullet to the "Network panel (link status)" section, explicit that it's a different code path from the #610/#623/#634 backend-choice probe already documented there (the networkd seed_links first-ListLinks retry, not probe_link_backend's NM-vs-networkd choice). Verified no other entry in the doc references an inert-until-restart networkd expectation.

New entries added

Left alone

Gates

  • Diff is markdown-only: git diff --stat → 1 file, docs/live-verify.md.
  • nix fmt run twice — 1 file reformatted the first pass (a prose reflow), 0 changed the second.
  • Clippy/tests deliberately skipped: nix/package.nix's crane source filter excludes markdown entirely, so a markdown-only diff produces a bit-identical trollshell-workspace derivation — running nix build would burn a full workspace recompile for zero signal (the same crane-filter trap docs: correct claims in CLAUDE.md, CHOOM-INIT.md and the etc/ deployment READMEs (#658, #659) #662's own PR body documents). Not run, per task instructions.

…urst falsified

Closes #660

Bring docs/live-verify.md current across the ten PRs that merged after the
last refresh (#634): #637, #639, #644, #645, #662, #663, #664, #666, #668,
plus #642 (coverage bump only, per the issue's own conclusion — its default
station-id fix needs no live-verify caveat since write_default_config only
touches an absent places.toml).

Corrected the #630 entry: it told a verifier to expect modal::close_all
tearing down with window.close(); #637 changed that call to destroy() after
#630 had already merged, so the entry named a call the code no longer makes
(exactly the issue's finding). Also added a new #645 entry to the Network
panel section for the networkd startup-refresh retry, since that path used to
latch "no link manager has answered yet" forever on a transient first-refresh
failure (curable only by a shell restart) and now self-heals — swept the rest
of the doc for the same class of falsified expectation (inert-until-restart)
and found nothing else affected; the wifi-side #609/#634 entries describe a
different code path and are unaffected.

New entries added:
- #637/#639 — the destroy()-not-close() sweep across the five trollshell
  overlays and the three remaining hytte-ui sites (bar.rs, popup.rs),
  including #637's WeakRef/toplevels()-count kanshi hot-plug gesture.
- #644/#663 — the RefCell-borrow-across-GTK-call sweep (31 sites total
  across overlays/modal.rs and the rest of the UI, incl. an 8-panel-wide
  reactive_list.rs helper and the control-center). Both documented with the
  same "nothing changes" honest pass condition #630 already used.
- #664 — mpris Auto chip fix + bare-string artist widening. Needs two live
  MPRIS players and a shell restart for the new CSS class, both called out.
- #666 — new top-level "Claude bridge" section for the keyless loopback
  shim, nobody has run this service live yet. Carries the PR's flagged
  riskiest assumption (hive-claude's SessionNotFound classification) with
  its journal tell.
- #668 — new top-level "D-Bus name ownership" section. Documents that
  recovery going from ~250ms to up to 5 minutes after a squatter exits is
  the expected cost of the fix, not a regression to file.

Left alone: #642 (no doc change needed beyond the coverage line, matching
the issue's own recommendation after checking places.toml's write-once
behavior); #637's abort_subscription/prompt.rs exclusions and #644/#663's
"deliberately not touched" sites (no live-visible behavior, nothing to
verify).

Gates: markdown-only diff (git diff --stat: 1 file, docs/live-verify.md).
nix fmt run twice (1 file reformatted first pass — a prose reflow — 0
changed second pass). Clippy/tests deliberately skipped: nix/package.nix's
crane filter excludes markdown, so the packaged derivation is unaffected and
a nix build would burn a full workspace recompile for zero signal (the same
crane-filter trap #662 already documented). nix build was not run, per
instructions.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(live-verify): fold in #637/#639/#642 and correct the #630 entry's close() → destroy()

1 participant