docs: fold #616-#625 into live-verify - #628
Merged
Merged
Conversation
Adds the five 2026-07-30 PRs that merged right behind #611/#615's refresh: #616 (build revision over D-Bus, into Control-center), #623 (bar network chip link_source fix, into Network panel), #624 (OSD survives a hot-plug, into Displays/compositor), #625 (hover hold survives a sticky/finite re-post, into Notifications), and #622 (docs-only spec-drift retractions, into the no-live-verify section). Updates the declared coverage line to #458 through #625. Docs-only change. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
… note Fact-check follow-up on #628: - #622's changelog line said only two of three "not in v1" plugin-widgets clauses had shipped, claiming arbitrary pixels/custom-drawing "still holds". The retraction note #622 itself added (2026-07-11-plugin-widgets-frontend-b.md:155-165) says the opposite: Node::Pixels (#284) shipped too, and only custom drawing (cairo/snapshot calls executed in-process) remains a live non-goal. Reworded to name the surviving non-goal explicitly rather than as a hyphenated pair, since the hyphenated phrasing is exactly what caused this to get re-merged a second time. - #624's suggestion to also try a connector-less/virtual output implied the OSD half of the check applies there too. It doesn't: osd::install (overlays/osd.rs:139-145) skips any monitor with no connector name by design, so no OSD card is ever expected on such an output, on either side of the fix. Only the bar-corner half (main.rs's unconditional drawer-open class bind) is exercisable there — scoped the note to say so. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This was referenced Jul 30, 2026
vibechoom
added a commit
that referenced
this pull request
Jul 30, 2026
…630/#634 (#636) PR #634 (closes #613) makes two existing entries actively wrong rather than merely stale, which is worse than a gap: a verifier following the old text would read a successful self-heal as a regression. Corrects both, per #635: - The #610 "restart NetworkManager" caveat no longer says the backend probe runs once at startup; it retries while inconclusive. The deferred re-probe gap now points at #633 (the genuinely-unsolved half — switching backends after one is already committed) instead of the closed #613. - The #609 entry no longer expects an `error!` pointing at `systemctl --user restart trollshell` on a transient probe failure. The shipped retry policy is unbounded and self-heals into a `RECOVERED` line instead of giving up. Also folds in the three PRs that merged alongside #634 since the doc's last refresh (#628): - #629 (closes #614): docs/plugin-env.md publishing to the Pages options-doc site, new "Documentation site (GitHub Pages)" section (deploy itself is outside `nix flake check` by design — flagged as a manual check). - #630 (closes #627): modal::close_all's borrow-timing fix, added to Shell chrome as a regression-only check — explicitly states that no observable change is the pass condition. - #634 itself: new Wi-Fi entry covering the INCONCLUSIVE/RECOVERED journal pair and the incidental startup-freeze fix. - #628: docs-only refresh of this file, noted in the closing section. Coverage line bumped to #458 through #634. Documentation-only change. Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only change. Folds the five PRs that merged in tonight's
2026-07-30 burst (right behind #611/#615's refresh) into
docs/live-verify.md:runtime over
Control.Revision. Added to Control-center, including thetwo-
TROLLSHELL_REVhazard (shell slice vs. control-center slice) and theforked-child env inheritance caveat called out in the task.
doc-comment line. Added to "Not carrying a live-verify list" since it
has nothing to verify at runtime.
link_source, notjust
primary. Added to Network panel (link status), alongside fix(network): tell "no link manager" apart from "offline" (#608) #610'sentries, covering the
network-idle-symbolicglyph and the sharedlink_status_texttooltip wording (bar vs. panel must agree, including theDegradedstate).Displays / compositor geometry & overlays, covering the drawer +
kanshi/replug + OSD-key sequence and the bar's
drawer-openseam corner.re-post. Added to Notifications, alongside feat(notifications): pause expiry while hovered — Closes #567 #569/fix(notifications): keep unchanged toast cards mounted, carry the hover hold across a rebuild #596.
Also updated the declared coverage line from
#458 through #611to#458 through #625, and added #622 to the list of PRs with no live-verify list oftheir own.
No source files touched —
docs/live-verify.mdonly.Test plan
nix fmt, then a second run reporting 0 files changed, then a thirdrun confirming it stays at 0 (hit the known inline-code-span-across-
line-break trap twice — in the fix(notifications): keep the hover hold across a sticky/finite re-post (#619) #625 and feat(revision): make the build's git commit reachable at runtime (#601) #616 entries — fixed by
shortening/relocating the spans rather than fighting the reflow).
git diff --statconfirms onlydocs/live-verify.mdchanged.none of feat(revision): make the build's git commit reachable at runtime (#601) #616/docs: retract two reversed non-goals + fix stale overlays doc (#617) #622/fix(widgets): bar network chip now honors link_source, not just primary #623/fix(osd): clear DRAWER_OPEN in close_all so a hot-plug can't latch it true (#618) #624/fix(notifications): keep the hover hold across a sticky/finite re-post (#619) #625 were mentioned anywhere in the file
before this change (grepped for all six issue/PR numbers), so there
was nothing to relocate out of a pending section.
🤖 Generated with Claude Code