Add brew trust to the brew install commands outside the shared CLI include#5216
Closed
btshrewsbury-viam wants to merge 1 commit into
Closed
Add brew trust to the brew install commands outside the shared CLI include#5216btshrewsbury-viam wants to merge 1 commit into
btshrewsbury-viam wants to merge 1 commit into
Conversation
Homebrew 6.0 refuses to load formulae from a tap the user has not explicitly trusted, so the documented tap-then-install sequence fails. PR #5214 adds the trust step to the shared CLI install include; this covers the two remaining brew blocks that do not use it: the inline copy in try/part-3.md and the viam-server one-liner in reference/viam-server.md. Part of #5215.
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
viambot
added
the
safe to build
Collaborator
Author
|
Closing in favor of #5214. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
brew trust viamrobotics/brewsto the two brew install command blocks that live outside the shared CLI install include:docs/try/part-3.md: the macOS tab inlines its own copy of the CLI install commands instead of readingstatic/include/how-to/install-cli.md.docs/reference/viam-server.md: the macOSviam-serverone-liner uses the same tap, so it hits the same trust gate. It becomesbrew tap viamrobotics/brews && brew trust viamrobotics/brews && brew install viam-server.Why
Homebrew 6.0 made tap trust mandatory: formulae from a third-party tap refuse to load until the user trusts the tap, so the documented tap-then-install sequence fails with
Refusing to load formula viamrobotics/brews/viam from untrusted tap. Trusting only the formula also fails, because theviamformula depends onnlopt-staticfrom the same tap. Full failure log and affected-page inventory: #5215.Relationship to #5214
#5214 (nathartman) fixes the shared include, which covers the CLI overview page and the four other pages that embed it. This PR covers the two remaining brew blocks that bypass the include. Together the two PRs close #5215; neither is complete alone.
Part of #5215.
Verification
prettier, markdownlint, vale (0 errors), and
make build-prodall pass.