Flash red lights and speak a snarky line when an order genuinely faults#256
Open
Daniel Botros (danielbotros) wants to merge 1 commit into
Open
Flash red lights and speak a snarky line when an order genuinely faults#256Daniel Botros (danielbotros) wants to merge 1 commit into
Daniel Botros (danielbotros) wants to merge 1 commit into
Conversation
Daniel Botros (danielbotros)
force-pushed
the
fault-lights-and-snark
branch
from
July 17, 2026 16:06
2a7c275 to
eeddcf6
Compare
Daniel Botros (danielbotros)
marked this pull request as ready for review
July 17, 2026 16:17
| "is_busy": s.running.Load(), | ||
| "current_step": step, | ||
| "can_serve_decaf": s.cfg.CanServeDecaf, | ||
| "fault_active": s.faultActive(), |
There was a problem hiding this comment.
I don't think we need faultActive() and lastFaultAt since we run s.reactToOrderFailure(r) on failure (similar to the Salck notification
On a genuine fault (not an operator cancel, which keeps its calmer spoken announcement), speak a snarky Cappuccina failure line through speech_service_name via sayAlways (best-effort, detached from the queue goroutine, 10s timeout) and raise a transient fault_active flag in Status() for a few seconds. The conversation-bundle stack (voice-command → led-bridge) renders the flag as a red LED flash; this service knows nothing about LEDs and gains no new config. Co-Authored-By: Claude Fable 5 <[email protected]>
Daniel Botros (danielbotros)
force-pushed
the
fault-lights-and-snark
branch
from
July 17, 2026 19:17
db18ac5 to
6cc1702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a genuine fault the machine now reacts in the room:
orderFailedtemplates spoken through the existingspeech_service_namepath viasayAlways, so it plays regardless of theconversationalsetting (same as the drink-ready announcement). Best-effort, detached from the queue goroutine, 10s timeout.fault_active: truein itsStatus()for 5 seconds. voice-command, which already watches this service'sStatus()as itscommand_statusresource, folds the flag into its lifecycle state aserror; the existing led-bridge poller forwards the state change and the firmware flashes red until the window lapses and the state reverts. See the companion PR Surface command-status faults as an "error" LED state viam-modules/conversation-bundle#20.This design keeps exactly one LED state owner (voice-command) and one serial writer (the led-bridge poller) — no arbitration logic, no magic service names, and no new config fields in this repo.
Both reactions hook into the existing failure fan-out (
notifyOrderReading). Tests cover the fault/cancel/success gating, the fault window expiry, the Status flag, the spoken snark payload, and the failure-line templates.go test ./...passes.🤖 Generated with Claude Code