Skip to content

Check packet flow for liveness#220

Merged
Sean Pollock (seanavery) merged 5 commits into
viam-modules:mainfrom
seanavery:liveness-frame-check
Jul 14, 2026
Merged

Check packet flow for liveness#220
Sean Pollock (seanavery) merged 5 commits into
viam-modules:mainfrom
seanavery:liveness-frame-check

Conversation

@seanavery

@seanavery Sean Pollock (seanavery) commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Description

Cache timestamp of last inbound frame, and validate against 10 second timeout duration during the liveness check.

If there is a frame timeout, we then check OPTIONS (only for diagnostics) and finally reconnect.

Tests

  • Added integration test to validate new liveness check behavior
  • Manually tested no issues on office RTSP cam

Comment thread rtsp.go Outdated
Comment thread test_utils.go
bURL *base.URL,
logger logging.Logger,
) (*ServerHandler, func()) {
rtspAddr := freeLocalTCPAddr(t)

@seanavery Sean Pollock (seanavery) Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple port fix for regression in MacOS test runner

@seanavery Sean Pollock (seanavery) changed the title Check packet flow for liveness check Check packet flow for liveness Jul 14, 2026
@seanavery
Sean Pollock (seanavery) merged commit 3aa8514 into viam-modules:main Jul 14, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants