expose vg describe to vg help#4947
Open
gtbil wants to merge 2 commits into
Open
Conversation
Contributor
|
It's already there vg/src/subcommand/describe_main.cpp Line 184 in e82694b (the clear copy-paste error is weird, yeah. I'm now considering adding to my option-checking script to force all the subcommand registrations to use the right names.) But it doesn't seem to affect the output. Running |
Contributor
|
You could shift the PR to fix the name and update the description, though I'm not sure how much more help that would be. Otherwise I feel inclined to close this. |
Contributor
|
OK, I've set the unit tests to run, and once they pass this can be merged. |
Contributor
|
Adam showed me how to actually trigger GitLab CI tests for PRs made by non vgteam members, so that's running. Usually takes some hours, then I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg describe, useful for detecting file types, throughvg helpDescription
Addresses a discussion in #4430 about the new
vg describesubcommand.