Backport #2525: perf(core): decouple workflow VM seed/clock from startedAt#2530
Open
github-actions[bot] wants to merge 1 commit into
Open
Backport #2525: perf(core): decouple workflow VM seed/clock from startedAt#2530github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Derive the deterministic RNG seed from `runId:workflowName:deploymentId` and the VM's initial fixed clock from the ULID timestamp embedded in `runId` (via the new `runIdCreatedAt` helper). All of these inputs are available the instant a queue message arrives, so the VM seed and clock no longer depend on `startedAt` (set only after the `run_started` round-trip). This is the prerequisite for starting VM initialization earlier on the critical path. This changes the seed-derived value sequence for a given run, so the affected deterministic test fixtures are regenerated accordingly. Signed-off-by: Nathan Rajlich <[email protected]>
🦋 Changeset detectedLatest commit: 18b1479 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
Author
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)nitro (1 failed):
🌍 Community Worlds (99 failed)redis (19 failed):
turso (80 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #2525 to
stable(backport job run).AI recommendation: This is a self-contained change to
@workflow/core's VM seed/clock derivation, and the targeted code (packages/core/src/workflow.ts, including the exact${runId}:${workflowName}:${+startedAt}seed formula it replaces) already exists onstable, so it does not build on any main-only API. It carries an in-flight-replay migration caveat that the included changeset documents, but the change applies equally to both branches and a human can review the resulting PR.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.