-
Notifications
You must be signed in to change notification settings - Fork 285
perf(core): precompile workflow vm.Script at module init #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TooTallNate
wants to merge
1
commit into
main
Choose a base branch
from
perf/script-precompile-module-init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@workflow/builders': patch | ||
| '@workflow/next': patch | ||
| --- | ||
|
|
||
| Pass the bundle's workflow source filenames to `workflowEntrypoint` in generated routes so the workflow VM script is precompiled at module-init time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@workflow/core': minor | ||
| --- | ||
|
|
||
| Precompile the workflow bundle `vm.Script` at module-init time via a new optional `workflowFilenames` option on `workflowEntrypoint`, so the first queue delivery's replay skips the bundle parse/compile cost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { | ||
| getWorkflowFilenamesFromManifest, | ||
| type WorkflowManifest, | ||
| } from './apply-swc-transform.js'; | ||
|
|
||
| describe('getWorkflowFilenamesFromManifest', () => { | ||
| it('returns an empty array for a manifest with no workflows', () => { | ||
| expect(getWorkflowFilenamesFromManifest({})).toEqual([]); | ||
| expect(getWorkflowFilenamesFromManifest({ workflows: {} })).toEqual([]); | ||
| }); | ||
|
|
||
| it('derives filenames from each workflowId module specifier', () => { | ||
| const manifest: WorkflowManifest = { | ||
| workflows: { | ||
| './src/jobs/order.ts': { | ||
| processOrder: { | ||
| workflowId: 'workflow//./src/jobs/order//processOrder', | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
| expect(getWorkflowFilenamesFromManifest(manifest)).toEqual([ | ||
| './src/jobs/order', | ||
| ]); | ||
| }); | ||
|
|
||
| it('deduplicates filenames across multiple functions in the same file', () => { | ||
| // Two workflow functions in the same source file share one module | ||
| // specifier, so the precompile target is a single filename — not one per | ||
| // function. | ||
| const manifest: WorkflowManifest = { | ||
| workflows: { | ||
| './src/jobs/order.ts': { | ||
| processOrder: { | ||
| workflowId: 'workflow//./src/jobs/order//processOrder', | ||
| }, | ||
| cancelOrder: { | ||
| workflowId: 'workflow//./src/jobs/order//cancelOrder', | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
| expect(getWorkflowFilenamesFromManifest(manifest)).toEqual([ | ||
| './src/jobs/order', | ||
| ]); | ||
| }); | ||
|
|
||
| it('returns a sorted set across multiple files', () => { | ||
| const manifest: WorkflowManifest = { | ||
| workflows: { | ||
| './src/b.ts': { | ||
| b: { workflowId: 'workflow//./src/b//b' }, | ||
| }, | ||
| './src/a.ts': { | ||
| a: { workflowId: 'workflow//./src/a//a' }, | ||
| }, | ||
| }, | ||
| }; | ||
| expect(getWorkflowFilenamesFromManifest(manifest)).toEqual([ | ||
| './src/a', | ||
| './src/b', | ||
| ]); | ||
| }); | ||
|
|
||
| it('falls back to the raw workflowId when it is not a parseable name', () => { | ||
| const manifest: WorkflowManifest = { | ||
| workflows: { | ||
| './src/weird.ts': { | ||
| weird: { workflowId: 'not-a-workflow-name' }, | ||
| }, | ||
| }, | ||
| }; | ||
| expect(getWorkflowFilenamesFromManifest(manifest)).toEqual([ | ||
| 'not-a-workflow-name', | ||
| ]); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor/nit:
getWorkflowFilenamesFromManifestalready returns a deduped, sorted array, so for the builder call sites thisnew Set(...).sort()is redundant work. It's harmless and reasonable as defensive normalization for direct callers ofcreateWorkflowEntrypointOptionsCode— just flagging the double dedup/sort in case you'd rather pick one layer to own it.