fix(streamdown): re-render memoized components when node offset changes#538
Open
julesyoungberg wants to merge 3 commits into
Open
fix(streamdown): re-render memoized components when node offset changes#538julesyoungberg wants to merge 3 commits into
julesyoungberg wants to merge 3 commits into
Conversation
Contributor
|
@julesyoungberg is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes stale DOM when markdown is updated in the middle of an existing block. Memoized leaf components (
ol,ul,p, headings, etc.) usesameNodePositionto skip re-renders, but it only comparedlineandcolumn. When content changed without updating line/column (onlyoffset, e.g. injecting a link mid-line), React kept stale output until Streamdown remounted.sameNodePositionis shared by all memoized markdown components viasameClassAndNode, so this fix applies broadly rather than to a single element type.Type of Change
Changes Made
offset?: numbertoMarkdownPointand compareposition.start.offset/position.end.offsetinsameNodePosition(packages/streamdown/lib/components.tsx)"should re-render when only offset changes"(packages/streamdown/__tests__/components-rerender.test.tsx).changeset/fair-balloons-share.md)Testing
pnpm exec vitest run __tests__/components-rerender.test.tsxAll 18 tests in that file pass.
Checklist
pnpm changeset)Additional Notes
No documentation or inline comment changes — this is an internal comparator fix with no API surface change. The new test documents the edge case.