fix: Escape unsafe JS characters in channel routes#770
Open
odaysec wants to merge 3 commits into
Open
Conversation
Updated dispatchChannelWebSocketRequest and dispatchChannelRequest to escape unsafe JavaScript code characters in routeKey.
Contributor
|
@odaysec is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
odaysec
commented
Jul 14, 2026
odaysec
left a comment
Author
There was a problem hiding this comment.
Use a dedicated escaping helper for values inserted into generated JavaScript module source. Keep JSON.stringify(...) (to preserve string-literal semantics) and then post-process to escape dangerous characters (<, >, /, backslashes, line separators, control chars) so generated module text cannot be broken by special sequences.
Best fix in this file:
- Add a local
charMapandescapeUnsafeJsCodeCharshelper near the existing constants/helpers. - Replace direct
JSON.stringify(routeKey)interpolations in generated export lines withescapeUnsafeJsCodeChars(JSON.stringify(routeKey)). - Keep behavior unchanged otherwise (same values, same routing logic, same module generation layout).
Signed-off-by: Jörmungandrk <[email protected]>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated dispatchChannelWebSocketRequest and dispatchChannelRequest to escape unsafe JavaScript code characters in routeKey.
Description
Using string concatenation to construct JavaScript code can be error-prone, or in the worst case, enable code injection if an input is constructed by an attacker.
The constructs a function that assigns the number 42 to the property
keyon an objectobj. However, ifkeycontains</script>, then the generated code will break out of a</script>if inserted into a</script>tag.PR Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)