Make authored dev rebuilds transactional#766
Open
ctgowrie wants to merge 2 commits into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
ctgowrie
force-pushed
the
feat/dev-transactional-rebuilds
branch
from
7a9481a to
23fe13e
Compare
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
feaf376 to
135761c
Compare
ctgowrie
force-pushed
the
feat/dev-transactional-rebuilds
branch
from
23fe13e to
ad8f262
Compare
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
0974216 to
b80e5e1
Compare
ctgowrie
force-pushed
the
feat/dev-transactional-rebuilds
branch
from
58c8b2a to
4bca06c
Compare
ctgowrie
force-pushed
the
feat/dev-transactional-rebuilds
branch
from
4bca06c to
f1e29bc
Compare
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
b80e5e1 to
4e2aafa
Compare
Signed-off-by: Casey Gowrie <[email protected]>
Staging keyed off the watcher's changed paths dropped an environment edit permanently when its rebuild failed for an unrelated reason: the failed attempt rolled the environment back and consumed the changed paths, so the retry committed without ever reapplying the edit. Stage from the files on disk on every rebuild instead; an unchanged environment stages as a no-op. Signed-off-by: Casey Gowrie <[email protected]>
ctgowrie
force-pushed
the
feat/dev-transactional-rebuilds
branch
from
f1e29bc to
a1da3f4
Compare
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
4e2aafa to
7dec777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dev rebuilds currently mutate the live Nitro host as files change. A failed compile, bundle, route update, or worker startup can therefore leave the server on a partial generation, and structural reloads can reset active requests.
What changed
This is Stage 4 of the staged dev isolation work. Stage 5 moves local Workflow ownership to the parent, resolves latest once per child turn, and prunes generations only after every request, worker, and non-terminal Workflow reference is gone.
Validation
pnpm lintpnpm typecheckpnpm guard:invariants