Implement support for multi-site data#33
Open
lexisother wants to merge 1 commit into
Open
Conversation
|
Addresses #2 |
Member
|
Thanks for this, appreciate it! I'll give it a look over to see if practical to merge, or if we want to tweak further for release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements very basic support for configuring a View to support retrieving data from multiple sites.
Currently this only supports environments where the root URL of all Craft sites is the same. (think of
$PRIMARY_SITE_URL/site1,$PRIMARY_SITE_URL/site2, etc)This because a Source can only be configured with one property/app, which are (typically) only for one single domain.
However, support for differing root domains can be added by adjusting the payload I added (and making whatever other necessary changes within Metrix):
There's no need to merge this PR as-is, or at all, at the very least this is a reference implementation for something that could be. For now, I will likely be running a fork of Metrix for a client that requested this functionality.