Skip to content

docs: endorsement lifecycle management API#74

Merged
thomas-fossati merged 5 commits into
veraison:mainfrom
MonakaResearch:main
May 19, 2026
Merged

docs: endorsement lifecycle management API#74
thomas-fossati merged 5 commits into
veraison:mainfrom
MonakaResearch:main

Conversation

@shefali-kamal
Copy link
Copy Markdown

API spec for activation/deactivation of triples using CoRIM IDs, CoMID IDs, or CoSERV query.
This is the SPEC whose implementation will resolves Github issue: veraison/services#402

API spec for activation/deactivation of triples using CoRIM
IDs, CoMID IDs, or CoSERV query.

Co-authored-by: Dhanus M Lal <[email protected]>
Co-authored-by: Kumar, Atul <[email protected]>
Signed-off-by: Kumar, Atul <[email protected]>
Copy link
Copy Markdown
Contributor

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- use coserv data model primitives to create endorsements lifecycle
  management (ELM) queries

>[!TODO]
> Migrate from application/problem+json (RFC 9457) to
> applicaton/concise-problem-details+cbor (RFC 9290).
> This change should be applied to other endpoints
> (and services) to maintain consistency in the response
> encondings. Better to address it in a future PR when
> consensus is reached on the response format(s).

Signed-off-by: Kumar, Atul <[email protected]>
Copy link
Copy Markdown
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Before merging, I’d like to discuss the position of the profile in the query.

Comment thread api/endorsement-provisioning/README.md Outdated
- remove profile from rim query
- move profile inside env query

Signed-off-by: Kumar, Atul <[email protected]>
Copy link
Copy Markdown
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(I have inlined a few, purely editorial, suggestions.)

Comment thread api/endorsement-provisioning/README.md Outdated
Comment thread api/endorsement-provisioning/README.md Outdated
Comment thread api/endorsement-provisioning/README.md Outdated
Comment thread api/endorsement-provisioning/README.md Outdated
Comment thread api/endorsement-provisioning/README.md Outdated
Comment thread api/endorsement-provisioning/README.md Outdated
Comment thread api/endorsement-provisioning/endorsement-provisioning.yaml Outdated
Comment thread api/endorsement-provisioning/README.md Outdated
@thomas-fossati thomas-fossati merged commit 5d17472 into veraison:main May 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants