visible-sleep-screen : new package#291
Closed
alefaraci wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visible-sleep-screensets visible content as sleep screen when "Visible content" (Settings ▸ Display ▸ "Visible content") is ON. It renders the stock screen when "Visible content" is OFF. The device still performs a real deep-sleep.Optional owner info: if Settings ▸ Security ▸ Personal information is ON, the sleep bar appends
Name – Contact.qt-resource-rebuilder.remarkable-os>=3.27 <3.28.Note on hashing: the hashtab is built per-device from that device's own xochitl, so tokens that exist on only one model (the two sleep-window paths,
folioClosed, the folio-peek ids) are deliberately left cleartext. Hashing them, I experienced that would make the file unresolvable on the other device, which fails the.qmdand every other installed mod with it. A fully-hashed multi-device.qmdisn't possible apparently; this is the reason the file looks partly cleartext. The wholeMainView.qmlblock is also kept cleartext on purpose. That exact form is the one I device-verified on both models.Testing
Device-verified end-to-end on:
tatsu, aarch64) — xochitl 3.27.3.1547Not tested:
ferrari)chiappa)I don't own either, so I want to be upfront about where they could break:
qml/tatsu/norqml/default/but a path of their own. Consequence is benign:qt-resource-rebuilderjust never matches it, so the sleep screen stays stock: no crash, no impact on other mods. (TheMainView.qmlblock would still apply, also benign: with the stock opaque sleep window on top nothing shows through, so the visible effect is only that the sleep-entry white flash is gone while "Visible content" is ON.) The fix would be one extraAFFECTline reusing the sameSLOT, once someone reports the path (or shares their xochitl).