enhancement(acknowledgements): support best-effort sink branches - #26143
Draft
Jansen-w wants to merge 1 commit into
Draft
enhancement(acknowledgements): support best-effort sink branches#26143Jansen-w wants to merge 1 commit into
Jansen-w wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft explores selective sink participation in end-to-end acknowledgements. A sink with
acknowledgements.enabled: falsebecomes a best-effort branch: it still receives events, but its event copies do not retain source finalizers and therefore cannot delay or affect the upstream acknowledgement result.The implementation:
Known prototype limitations
References
None.
Vector configuration
How did you test this PR?
cargo test -p vector-core fanout::tests --libcargo test -p vector --features sources-file,sinks-file config::acknowledgements_tests::propagates_settings --libcargo test -p vector --features sources-http_server,sinks-http topology::test::end_to_end --libcargo check -p vector --libcargo clippy -p vector-core --tests -- -D warningscargo clippy -p vector --lib --features sources-http_server,sinks-http,sources-file,sinks-file -- -D warningscargo fmt --all -- --checkcargo vdev check changelog-fragmentsThe end-to-end test blocks a failing best-effort HTTP sink and verifies that the HTTP source responds successfully as soon as the required sink succeeds.
Is this a breaking change?
Does this PR include user facing changes?