Skip to content

feat(datadog sinks): validate config at compile time - #26142

Merged
thomasqueirozb merged 2 commits into
masterfrom
datadog-sinks-validation
Aug 18, 2026
Merged

feat(datadog sinks): validate config at compile time#26142
thomasqueirozb merged 2 commits into
masterfrom
datadog-sinks-validation

Conversation

@thomasqueirozb

Copy link
Copy Markdown
Member

Summary

Migrate the datadog_events, datadog_logs, datadog_metrics, and datadog_traces sinks to the validated config lifecycle: structural validation now runs at config-compile time and the validated state is retained for build.

References

Related: #26048

Vector configuration

NA

How did you test this PR?

  • make check-clippy with sinks-datadog_events,sinks-datadog_logs,sinks-datadog_metrics,sinks-datadog_traces features
  • make test with the same features, SCOPE="-E 'test(datadog)'" (119 passed)

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them. To catch issues early, add a pre-push hook (template) or run the following locally before pushing:
    • make fmt
    • make check-clippy (auto-fix with make clippy-fix)
    • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 18, 2026
@github-actions github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Aug 18, 2026
@thomasqueirozb
thomasqueirozb marked this pull request as ready for review August 18, 2026 18:54
@thomasqueirozb
thomasqueirozb requested a review from a team as a code owner August 18, 2026 18:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a9f2bf5e2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/sinks/datadog/events/config.rs Outdated
@thomasqueirozb

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 93544b9a81

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@thomasqueirozb
thomasqueirozb added this pull request to the merge queue Aug 18, 2026
Merged via the queue into master with commit 304ef8f Aug 18, 2026
96 of 98 checks passed
@thomasqueirozb
thomasqueirozb deleted the datadog-sinks-validation branch August 18, 2026 20:51
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants