Skip to content

feat(aws sinks): validate config at compile time - #26141

Merged
pront merged 3 commits into
masterfrom
aws-sinks-validation
Aug 18, 2026
Merged

feat(aws sinks): validate config at compile time#26141
pront merged 3 commits into
masterfrom
aws-sinks-validation

Conversation

@thomasqueirozb

Copy link
Copy Markdown
Member

Summary

Refactor AWS sinks to validate config up front via the validated-config pattern, including header validation, and make ssekms_key_id respect the configured timezone.

References

NA

Vector configuration

NA

How did you test this PR?

NA

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them. To catch issues early, add a pre-push hook (template) or run the following locally before pushing:
    • make fmt
    • make check-clippy (auto-fix with make clippy-fix)
    • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@github-actions github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Aug 18, 2026
@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 18, 2026
@thomasqueirozb
thomasqueirozb marked this pull request as ready for review August 18, 2026 17:57
@thomasqueirozb
thomasqueirozb requested a review from a team as a code owner August 18, 2026 17:57
@thomasqueirozb thomasqueirozb changed the title enhancement(aws sinks): use validated config pattern feat(aws sinks): validate config at compile time Aug 18, 2026
Comment thread changelog.d/aws_s3_ssekms_key_id_timezone.enhancement.md
@thomasqueirozb

Copy link
Copy Markdown
Member Author

@codex review

@thomasqueirozb thomasqueirozb removed the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 18, 2026
@pront
pront enabled auto-merge August 18, 2026 18:10
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: cd83afc2fd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@thomasqueirozb
thomasqueirozb requested a review from a team as a code owner August 18, 2026 18:18
@github-actions github-actions Bot added the domain: external docs Anything related to Vector's external, public documentation label Aug 18, 2026
@pront
pront added this pull request to the merge queue Aug 18, 2026
Merged via the queue into master with commit 77a3749 Aug 18, 2026
61 checks passed
@pront
pront deleted the aws-sinks-validation branch August 18, 2026 19:54
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants