Skip to content

feat: changelog docs major improvement - #26138

Merged
pront merged 1 commit into
masterfrom
pront-changelog-types
Aug 18, 2026
Merged

feat: changelog docs major improvement#26138
pront merged 1 commit into
masterfrom
pront-changelog-types

Conversation

@pront

@pront pront commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

Centralize the changelog fragment type list in a single source of truth and expose it
through a new vdev changelog types subcommand, so the scaffolder, CI checker, and release
generator no longer maintain duplicated lists (the checker previously carried a
"keep this list in sync" comment). Update changelog.d/README.md to reference the command
instead of hardcoding the types, and add guidance for both humans and agents.

References

No issue.

Vector configuration

N/A — this PR touches vdev developer tooling and changelog.d/README.md only.

How did you test this PR?

  • cargo check -p vdev
  • cargo test -p vdev — 116 passed (including a new test for vdev changelog types)
  • cargo clippy -p vdev --all-targets
  • cargo fmt -p vdev -- --check
  • vdev check markdown — 0 issues across 707 files
  • Verified live: vdev changelog types prints each type with its description (e.g.
    breaking A change that is incompatible with prior versions and requires users to make adjustments...),
    and vdev changelog --help lists the new subcommand.

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them. To catch issues early, add a pre-push hook (template) or run the following locally before pushing:
    • make fmt
    • make check-clippy (auto-fix with make clippy-fix)
    • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@pront
pront requested a review from a team as a code owner August 18, 2026 13:41
@github-actions github-actions Bot added the domain: vdev Anything related to the vdev tooling label Aug 18, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ffbadf8a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vdev/src/commands/changelog/mod.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2518bd1d6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread changelog.d/README.md Outdated
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 18, 2026
@pront
pront force-pushed the pront-changelog-types branch from a83421f to 47cecd0 Compare August 18, 2026 13:58

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82fdceef64

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vdev/src/commands/changelog/mod.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bfd46bc359

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vdev/src/commands/changelog/mod.rs
@pront pront changed the title Add vdev changelog types command and improve changelog docs feat: changelog docs major improvement Aug 18, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 871fcfda43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread vdev/src/commands/check/changelog_fragments.rs Outdated
Centralize the changelog fragment type list in a single source of truth
(`FRAGMENT_TYPES` in vdev/src/commands/changelog/mod.rs), where each type
carries a name, description, release CUE type, and breaking flag, and expose
it through a new `vdev changelog types` subcommand. The scaffolder, CI
checker, and release CUE generator all derive from the shared definition
instead of maintaining duplicated lists or hard-coded matches.

Restructure changelog.d/README.md: add prerequisites/install guidance,
clarify when a fragment is needed, document what a good fragment should
answer, reference `vdev changelog types` as the source of truth for types
and their descriptions, and clarify that the authors line is required.

Bump vdev to 0.3.15.
@pront
pront force-pushed the pront-changelog-types branch from ad2dac0 to f6a731a Compare August 18, 2026 19:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6a731a461

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread changelog.d/README.md
@pront
pront enabled auto-merge August 18, 2026 19:36
@pront
pront added this pull request to the merge queue Aug 18, 2026
Merged via the queue into master with commit 7086e16 Aug 18, 2026
148 checks passed
@pront
pront deleted the pront-changelog-types branch August 18, 2026 20:40
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants