table: validate index bounds in sqfs_table_get#155
Merged
Conversation
Store the entry count from sqfs_table_init and check that idx is within bounds before indexing into the blocks array. Without this, a crafted SquashFS image with a large uid, fragment index, or xattr index can cause sqfs_table_get to read past the allocated blocks array. Fixes vasi#154
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store the entry count passed to
sqfs_table_init()and validate thatidxis within bounds insqfs_table_get()before indexing into theblocksarray. Without this check, a crafted SquashFS image with a large uid, fragment index, or xattr index causes an out-of-bounds read past the heap-allocatedblocksarray.Fixes #154