fix(isPassportNumber): anchor MZ and PH alternations#2790
Open
chatman-media wants to merge 1 commit into
Open
Conversation
The Mozambique and Philippines patterns put the alternation outside the
anchors, so ^ bound only to the first branch and $ only to the last.
That let arbitrary leading/trailing characters slip through, e.g.
isPassportNumber('AB0808212XXXX', 'MZ') and
isPassportNumber('X123456ZZZ', 'PH') returned true. Wrapping each
alternation in a group fixes it, matching how CA/CN/EE are already
written. Added the junk-padded cases to the test fixtures.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2790 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2587 2587
Branches 656 656
=========================================
Hits 2587 2587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mozambique and Philippines passport patterns put the
|outside the anchors, so^only applied to the first branch and$only to the last. That meant any extra characters before or after a valid number slipped through:Wrapping each alternation in a group so both anchors bind to every branch — same shape as the CA/CN/EE entries already use. All the existing valid/invalid fixtures still behave the same; I added the junk-padded cases above to the MZ and PH tests so the regression is covered.