fix(isCreditCard): anchor Mastercard regex#2788
Open
TisanSmart232 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2788 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2587 2587
Branches 656 656
=========================================
Hits 2587 2587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Mastercard provider regex so it has one set of anchors around the whole expression.
Before this change, the first Mastercard branch was anchored only at the start:
/^5[1-5][0-9]{2}|...$/That allowed strings that start with a valid 51-55 Mastercard prefix to pass the provider regex even when they have extra trailing digits. If the full string also happens to pass the Luhn check,
isCreditCardcan returntruefor an invalid Mastercard length.Before:
After:
The change is limited to
isCreditCardand adds a regression case for both the default validator path and the explicit{ provider: 'Mastercard' }path.Checklist
Tests
npm run lintnpx mocha --require @babel/register --reporter dot test/validators.test.js --grep "credit cards"npm test