Skip to content

失敗時のメッセージに実際の値を表示するようにした #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diskit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

失敗時のメッセージに実際の値を表示するようにした #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions playtest-http/src/main/kotlin/com/uzabase/playtest2/http/proxy/ResponseBodyProxy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,23 @@ class ResponseBodyProxy private constructor(val body: Path) : ShouldBeString, Sh
}

// FIXME need more explained
override fun shouldBe(expected: String): TestResult =
if (body.toFile().readText(Charsets.UTF_8) == expected) {
override fun shouldBe(expected: String): TestResult {
val actual = body.toFile().readText(Charsets.UTF_8)
return if (actual == expected) {
Ok
} else {
Failed { simpleExplain(expected, body) }
Failed { simpleExplain(expected, actual) }
}
}

override fun shouldContain(expected: String): TestResult =
if (body.toFile().readText(Charsets.UTF_8).contains(expected)) {
override fun shouldContain(expected: String): TestResult {
val actual = body.toFile().readText(Charsets.UTF_8)
return if (actual.contains(expected)) {
Ok
} else {
Failed { simpleExplain(expected, body) }
Failed { simpleExplain(expected, actual) }
}
}

override fun toJsonPathProxy(path: String): JsonPathProxy =
body.toFile().readText(Charsets.UTF_8)
Expand Down
18 changes: 14 additions & 4 deletions playtest-http/src/test/kotlin/com/uzabase/playtest2/http/proxy/ResponseBodyProxyTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ class ResponseBodyProxyTest : FunSpec({
| value: Hello, world!!
| class: kotlin.String
|Actual:
| value: [^\s]+/com/uzabase/playtest2/http/proxy/response-body.txt
| class: sun.nio.fs.UnixPath
| value: Hello, world
| class: kotlin.String
""".trimMargin()
)
}
Expand All @@ -50,9 +50,19 @@ class ResponseBodyProxyTest : FunSpec({
}

test("should not contain") {
fromClasspathToResponseBodyProxy("com/uzabase/playtest2/http/proxy/response-body.txt")
val result = fromClasspathToResponseBodyProxy("com/uzabase/playtest2/http/proxy/response-body.txt")
.shouldContain("world!!")
.shouldBeInstanceOf<Failed>()
result.shouldBeInstanceOf<Failed>()
result.explain().shouldMatch(
"""
|Expected:
| value: world!!
| class: kotlin.String
|Actual:
| value: Hello, world
| class: kotlin.String
""".trimMargin()
)
}
}

Expand Down