Usability improvments#1
Open
maboiteaspam wants to merge 8 commits into
Open
Conversation
Add POST action to trainer app to save results as a file. Added jquery dependency to make POST request. Updated gitignore ot ignore the results.json file.
Author
|
Hi @jheer any interest into that PR ? |
Member
|
Thanks for the PR! Overall, this looks good to me. The only reservation is the inclusion of jquery, which seems unnecessary for just making a POST call. Why not use |
Author
|
yeah agreed. Just could not make that work when i worked on it ! I ll try to catch up soon on this so you can merge. |
Author
|
i ll rebase those commits later, don t worry. As soon as i dig the d3/jquery weirdness. It gives support to put a background under the designer zone to help drawing the gesture. Useful when you have weird gestures to prepare. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi those are some small adjustments to improve usability.
HTH
Add a webserver to start the trainer in a glance.
Add POST action to trainer app to save results as a file.
Added jquery dependency to make POST request.
Updated gitignore ot ignore the results.json file.