Rename "OA evidence" terminology to "deposit warrant"#111
Open
boyechko wants to merge 1 commit into
Open
Conversation
vedant1711
reviewed
May 26, 2026
The oa_* spiders were misnamed: they don't collect "evidence", nor are they specifically about "open access" (OA). They gather data that can establish a basis for depositing an article in the university's repository. This is a pure code-level rename with no behavior or schema change: - spiders: oa_evidence/oa_doaj/oa_license -> deposit_warrant/doaj/doi_license (BaseDepositWarrantSpider, DOAJSpider, DOILicenseSpider) and their methods - model: ArticleOAEvidence -> ArticleDepositWarrant (table name pinned via __tablename__, so no migration is needed) - enum: OAEvidenceKind -> DepositWarrant
boyechko
force-pushed
the
refactor/rename-oa-evidence
branch
from
June 10, 2026 16:51
796638f to
92c5463
Compare
Collaborator
Author
|
This PR was trying to do too many things at once. I scaled it back to pure renames in the code without any DB changes. |
Collaborator
|
Looks good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oa_evidence→deposit_warrant;oa_doaj→doaj;oa_license→doi_licenseEnum values cleaned (now justLICENSE,JOURNAL,MANUAL,FACULTY)Alembic migration foldsVERSION_AVAILABLEandFACULTY_AUTHORintoFACULTY