Conversation
…ork. trying a different way.
|
I added build documentation for Linux as well. |
| ### With CMake CLI | ||
| In the terminal at the root folder of this project run: | ||
| ``` | ||
| cmake -Bbuild -S. -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_ROOT\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET=x64-linux -DPRESET_NAME={linux-debug | linux-release} |
There was a problem hiding this comment.
this should probably be $VCPKG_ROOT, iirc $env:<something> is a powershell thing
There was a problem hiding this comment.
and -Bbuild seems to not be working; CMake presets seem to force -Bout/build/linux-debug? (same for the cmake --build command)
| ### Build Packages | ||
| For Ubuntu/Debian install: | ||
| ``` | ||
| sudo apt-get install build-essential git \ |
There was a problem hiding this comment.
python3-jinja2 might be missing on some debian installs
| @@ -1 +1 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
#include <vector> seems to be missing in this header? seems to cause build errors at least on my machine
| cmake -Bbuild -S. -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE="$env:VCPKG_ROOT\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET=x64-linux -DPRESET_NAME={linux-debug | linux-release} | ||
| cmake --build build | ||
| ``` | ||
| The resulting binary will be located at `out\install\{linux-debug | linux-release}\bin\ArrowVortex` |
There was a problem hiding this comment.
seems to be located in out/build/linux-debug/src/System/ArrowVortex, maybe this is for the installation, not building?
| float getScaleFactor() const override { return myScale; } | ||
|
|
||
| bool getWindowState() const override { | ||
| auto temp = SDL_GetWindowFlags(window); |
There was a problem hiding this comment.
Is the temp variable required?
Finally, we're ready for multiplatform support.
This PR was only tested on Windows WSL so far. I'll test more during the review process but this seems to work well enough for now.
The following changes were made:
I would like some review of the CMakeLists.txt for any simplifications/optimizations.
For testing builds you may need to install all the packages listed in release.yml with your distro's package manager: