You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds alias support to Hook::param(), allowing a parameter to be matched under one or more alternative names when the canonical key is absent from both $requestParams and $values. The implementation in Base::prepare() correctly prioritises the canonical key and falls back to the first matching alias for both lookup sources.
Confidence Score: 5/5
Safe to merge — the alias resolution logic is correct and backward-compatible.
No P0 or P1 issues found. The alias resolution correctly handles canonical-key precedence, empty alias lists, and lookup in both $requestParams and $values. The previously flagged test-coverage gap is a P2 concern that does not affect correctness.
No files require special attention.
Important Files Changed
Filename
Overview
src/Servers/Hook.php
Adds optional aliases parameter (default []) to param() method and stores it in the params array — clean, backward-compatible addition.
src/Servers/Base.php
Implements alias resolution for both $requestParams and $values in prepare(); canonical key takes precedence when present, first matching alias used otherwise. Logic is correct.
tests/Servers/Unit/HookTest.php
Adds two unit tests verifying alias storage in Hook::param(); integration tests for actual resolution in Base::prepare() are absent (previously flagged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.