Skip to content

Fix http request logger help text - #670

Merged
utksh1 merged 6 commits into
utksh1:mainfrom
anshikaagr:fix-http-request-logger-help-text
Jun 10, 2026
Merged

Fix http request logger help text#670
utksh1 merged 6 commits into
utksh1:mainfrom
anshikaagr:fix-http-request-logger-help-text

Conversation

@anshikaagr

Copy link
Copy Markdown
Contributor

Description

Added help text for the HTTP Request Logger plugin target field.

Changes include:

  • Added user-facing help text explaining the expected target URL input and plugin behavior.
  • Refreshed the plugin checksum after updating metadata.

Related Issues

Closes #525

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Updated the plugin metadata with descriptive help text.
  • Refreshed the checksum using:
py scripts/refresh_plugin_checksum.py --plugin http_request_logger
  • Verified the metadata diff contains only the help text addition and checksum update.

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@utksh1 utksh1 added level:beginner 20 pts difficulty label for small beginner-friendly PRs type:docs Documentation work category bonus label type:testing Testing work category bonus label area:plugins Scanner plugin metadata, schemas, or plugin runtime work area:backend Backend API, database, or service work labels Jun 8, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs cleanup before merge. The PR bundles testing/backend/unit/test_request_middleware.py, which is already covered by #669, and the current backend-tests job is failing. Please rebase on latest main, remove the duplicate request middleware test file from this PR, and keep the diff focused on the http_request_logger metadata help text/checksum update.

@anshikaagr

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I've removed the unrelated test_request_middleware.py file from this branch and kept the PR focused on the http_request_logger metadata help text and checksum update. CI has been rerun.

@utksh1 utksh1 added the gssoc:approved Admin validation: approved for GSSoC scoring label Jun 10, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after maintainer cleanup. The PR is now focused on plugin field help text and the affected plugin checksum validates locally.

@utksh1
utksh1 merged commit 3838308 into utksh1:main Jun 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend Backend API, database, or service work area:plugins Scanner plugin metadata, schemas, or plugin runtime work gssoc:approved Admin validation: approved for GSSoC scoring level:beginner 20 pts difficulty label for small beginner-friendly PRs type:docs Documentation work category bonus label type:testing Testing work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PLUGINS] Add field help text for http_request_logger metadata

2 participants