Fix/nuclearpurge localstorage - #664
Merged
utksh1 merged 5 commits intoJun 8, 2026
Merged
Conversation
… of clearing all localStorage
… of clearing all localStorage
Contributor
Author
|
Hi @utksh1 , I have addressed the issue. Could you please review the PR when you get a chance? |
utksh1
approved these changes
Jun 8, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Approved. The purge action now removes SecuScan-owned localStorage keys without clearing unrelated browser storage, and the behavior is covered by a focused Settings test. CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The handleNuclearPurge function was calling localStorage.clear() which wiped all browser storage indiscriminately, including keys that don't belong to SecuScan. This fix replaces it with a targeted approach that only removes SecuScan-owned keys.
Related Issues
Closes #464
Type of Change
How Has This Been Tested?
Added a unit test in SettingsSaveReset.test.tsx that:
Checklist