Fix/theme toggle UI - #2475
Open
Ritikyadav2004 wants to merge 7 commits into
Open
Conversation
…olor-mix configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue where the theme toggle button only updated the logo/assets and failed to trigger a global UI color scheme transition (dark mode) for the rest of the application.
Root Cause:
Tailwind CSS v3 automatically wraps CSS variables defined in strings (like
var(--bg-primary)) inrgb(var(...) / opacity)to support opacity modifiers, assuming the CSS variables contain raw RGB values. Since our CSS variables inindex.cssare defined as hex colors (e.g.#0a0b0d), this resulted in invalid CSS (e.g.rgb(#0a0b0d / 1)) being generated, causing the browser to ignore the background and text color declarations.Solution:
Modified
frontend/tailwind.config.jsto define color mappings using standard CSScolor-mixstrings (e.g.,color-mix(in srgb, var(--bg-primary) 100%, transparent)). This prevents Tailwind's defaultrgb(...)wrapping, and outputs valid, browser-compatible CSS variables.Related Issues
Closes #2353
Type of Change
How Has This Been Tested?
npm run test), validating all 566 tests successfully.npx playwright test), passing all core theme toggling and settings persistence tests.npm run build).Checklist