fix(tests) : add unauthed_client fixture for saved-views auth tests - #2200
Closed
tmdeveloper007 wants to merge 1 commit into
Closed
fix(tests) : add unauthed_client fixture for saved-views auth tests#2200tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
Add unauthed_client fixture without dependency override so auth-rejection tests exercise the real require_api_key function. Update test_unauthenticated_request_rejected and test_wrong_api_key_rejected to use unauthed_client instead of app_client (which bypasses auth). Fixes backend-unit failures where these tests were asserting 200 == 401 because the app_client fixture unconditionally overrode require_api_key.
utksh1
added
area:backend
ChatGPT Codex Connector
Owner
utksh1
added
the
gssoc:invalid
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2195.
Summary of What Has Been Done:
Added an unauthed_client fixture to test_saved_views.py that creates a FastAPI app with saved_views_router but WITHOUT the dependency override for require_api_key. Updated test_unauthenticated_request_rejected and test_wrong_api_key_rejected to use this fixture instead of app_client.
Changes Made:
Impact it Made:
Fixes the backend-unit test failures where these tests were asserting 200 == 401. The app_client fixture unconditionally bypassed auth, so the tests never actually verified auth enforcement. The unauthed_client lets the real require_api_key run.
Note: This task is being handled by tmdeveloper007 -- please assign to that account when picking it up.