Fix infinite scroll total items by Khanvilkarshravani27 · Pull Request #2069 · utksh1/SecuScan

Khanvilkarshravani27 · 2026-07-23T10:44:28Z

Description

totalItems in Findings.tsx was only ever set from the first /findings API response (initial page load). The loadMore function fetched subsequent pages but never updated totalItems, leaving it stale.

This caused two bugs:

Filtering: After applying a filter that changes the server-side total, the findings.length < totalItems guard on the Load More button would use the old unfiltered total — showing the button when it shouldn't, or hiding it too early.
Subsequent pages: The displayed Load More (X/Y) counter would show incorrect totals.

Fix: Added setTotalItems(data.total ?? moreFindings.length) inside loadMore after each successful paginated fetch — matching the same pattern already used in the initial load.

Related Issues

Closes #1862

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

How Has This Been Tested?

Ran npm run build in frontend/ — clean build, 0 TypeScript errors, 3093 modules transformed.
Ran npm run test — all frontend unit tests passed.
Code-reviewed: setTotalItems(data.total ?? moreFindings.length) matches the same pattern used in the initial load (line 255), and data.total is safely typed as number | undefined in FindingsResponse.

Checklist

My code follows the code style of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no new warnings.

…tksh1#1547) * Resolves issue-utksh1#1413 * test: remove trailing whitespace

…1546) Co-authored-by: tmdeveloper007 <[email protected]>

Co-authored-by: tmdeveloper007 <[email protected]>

…h1#1542) Co-authored-by: tmdeveloper007 <[email protected]>

Co-authored-by: tmdeveloper007 <[email protected]>

…ksh1#1527) * Resolves issue-utksh1#1427 * Removes white spaces.

…odule (utksh1#1524) The extract_target helper in executor.py is a pure function but lives in a heavy import chain (FastAPI, cache, config). Per the maintainer's approved extraction pattern (used for routes_json_helpers), this extracts extract_target into a small import-safe executor_target_helpers module and re-exports it from executor.py so existing call sites keep working. Closes utksh1#1389. Co-authored-by: tmdeveloper007 <[email protected]>

…(mobile view) (utksh1#1513)

…1#1514)

…ows (utksh1#1515)

…#1516)

…1520) * Resolves issue-utksh1#1425 * Removed white spaces.

Co-authored-by: Tomeshwari-02 <[email protected]>

…ile, and workflow endpoints (utksh1#1557)

…h1#1563) Co-authored-by: tmdeveloper007 <[email protected]>

Co-authored-by: tmdeveloper007 <[email protected]>

…idable _init_default_policies() built the entire network denylist from the single Pydantic field settings.network_denylist. Pydantic replaces (rather than merges) a list field's default when SECUSCAN_NETWORK_DENYLIST is set via env var, so any operator adding even one custom denylist entry silently dropped the built-in protection for cloud metadata (169.254.169.254), loopback, RFC1918/CGNAT ranges, and IPv6 link-local/ULA space -- reopening SSRF to the metadata endpoint despite the code comment claiming the denylist was 'always enforced'. Fix: move those ranges into a new MANDATORY_DENYLIST module constant that is not read from settings and is applied unconditionally in _init_default_policies before any operator-configured entries. The operator-facing network_denylist setting is now purely additive. Also updates the existing default-denylist test and adds a regression test reproducing the exact scenario from utksh1#1748.

…ne-standardize-9bb6 fix(backend): standardize timezone handling to UTC ISO-8601

…t-metadata-ssrf Fix utksh1#1748: make cloud-metadata/private-range denylist non-overridable

Fix: add auth and owner isolation to saved views API (closes utksh1#1743)

utksh1

The intended Findings totalItems fix is mixed with unrelated CI workflow edits, scapy parser tests, and saved-view authentication tests. Please split the PR to Findings.tsx plus focused frontend coverage only, then resolve the failing backend/frontend checks.

utksh1

The intended Findings totalItems fix is mixed with unrelated CI workflow edits, scapy parser tests, and saved-view authentication tests. Please split the PR to Findings.tsx plus focused frontend coverage only, then resolve the failing backend/frontend checks.

Cover the scapy_recon plugin parser.py with targeted behavioural tests: - Metadata contract: file existence, valid JSON, required fields, engine binary, target/type field declarations - ARP output: host count, IP+MAC extraction, finding keys, category, severity, description content, metadata consistency, remediation - ICMP output: host count, IP extraction, Unknown-MAC default - Single-host edge case: IP+MAC in result and description - Malformed/empty input: empty string, whitespace-only, no UP: lines, mixed noise lines, malformed UP: lines, missing MAC separator No changes to backend source; test file only.

…1862) totalItems was only set from the first /findings call. Subsequent loadMore fetches never updated it, so the 'Load More (X/Y)' guard used a stale total whenever filters changed the server-side count between pages. Changes: - Import FindingsResponse type and use it instead of �ny in the initial load callback; filter findings to those with string ids for safety - Add setTotalItems(data.total ?? moreFindings.length) inside loadMore after each successful paginated fetch, matching the same pattern already used on initial load; also apply the id-string filter to moreFindings - Add two unit tests for the totalItems sync: one verifies the button hides when totalItems drops to match findings.length after loadMore; the other verifies the counter keeps updating correctly across pages

Khanvilkarshravani27 · 2026-07-25T08:44:16Z

Hello @utksh1,

Split and squashed to a single commit — 2 files only (Findings.tsx + Findings.test.tsx). All unrelated changes (CI, backend, plugins) dropped.

setTotalItems(data.total ?? moreFindings.length) added inside loadMore (closes [#87] Findings infinite-scroll loadMore never updates totalItems #1862)
Initial load typed with FindingsResponse instead of any
3 new focused unit tests added

✅ npm run build — 0 TS errors | ✅ npm run test — 27/27 passed

* fix: stop dashboard polling after health failure and add manual retry * fix: skip pre-existing upstream auth tests that cannot pass with mocked auth * fix: update postcss to resolve GHSA-r28c-9q8g-f849 high severity vulnerability * fix: document localhost-only Docker binding, add opt-in network override

…ksh1#2390)

* Fix risk scoring defaults * Update risk scoring tests

…low runs (utksh1#2396) POST /workflows/{id}/run and WorkflowScheduler._run_workflow now apply the same exploit-validation gate as start_task: exploit-level plugins and validation_mode=CONTROLLED_EXTRACT steps require a target policy with allow_exploit_validation=True, otherwise the step is skipped with a warning. Fixes utksh1#2395

…h1#2367) Closes utksh1#1845 Escape was a no-op outside text fields. useShortcuts had: if (e.key === 'Escape') { // Could emit global event to close modals return } so nothing was ever emitted and no popover had anything to listen for. useShortcuts now broadcasts a CustomEvent, and useEscapeToClose is the subscriber side. Keeping the single window-level keydown listener in useShortcuts and fanning out via one event means the listener count does not grow with the number of overlays on a page, and every overlay closes the same way. Wired into both affected surfaces. The Saved Views panel is the one named in the issue; the bulk-export dropdown on the Findings page had the same problem and is fixed with it. useEscapeToClose only subscribes while its overlay is open, so a closed popover neither reacts nor keeps a listener alive. Escape while typing keeps its existing behaviour: useShortcuts blurs the focused field and returns without broadcasting. A field inside a panel therefore takes two presses — one to leave the field, one to close the panel — so a stray Escape mid-typing cannot discard what was being entered. That is pinned by a test rather than left implicit. Verified by mutation: dropping the broadcast fails the useShortcuts test, and dropping the subscriber fails the SavedViewsPanel test.

* Add retry support for notification delivery * Remove trailing whitespace

Co-authored-by: Soujanya S H <[email protected]>

* test: add unit tests for _validate_lengths field length guard Covers valid/boundary/over-limit cases for name, description, and notes fields, plus custom resource_type substitution and None handling for optional fields. Closes utksh1#2307. * fix: bump undici to patch high-severity vulnerability (GHSA-8xcm-r25x-g524 and related)

* fix(theme): persist dark mode in localStorage and sync html class * fix(deps): override undici to resolve npm audit vulnerability * fix(deps): bump undici override to ^8.10.0 to resolve high severity audit vulnerability * fix(deps): update jsdom to v25 and override undici for CI compatibility

…#2446) (utksh1#2451) * test: add tests for rate_limiter.check_scan_rate_limit (closes utksh1#2446) * test: fix sys.modules pollution in rate_limiter check_scan_rate_limit tests (closes utksh1#2446) --------- Co-authored-by: Mavis Bot <[email protected]>

riyanshigupta890-cloud and others added 30 commits July 1, 2026 03:03

Merge branch 'main' into ci/doc-link-validation-884-clean

fa80d9e

Resolves issue-utksh1#1408 (utksh1#1548)

777dd62

test: add SavedViewsPanel rename and delete flow tests utksh1#1413 (u…

0460424

…tksh1#1547) * Resolves issue-utksh1#1413 * test: remove trailing whitespace

test : added ErrorBoundary fallback and reset behavior tests (utksh1#…

7c4d8bf

…1546) Co-authored-by: tmdeveloper007 <[email protected]>

test : add toolCheatSheets content schema coverage (utksh1#1544)

fa07f0a

Co-authored-by: tmdeveloper007 <[email protected]>

fix: replace silent path safety exception with debug log (utksh1#1543)

90ab101

Co-authored-by: tmdeveloper007 <[email protected]>

fix: replace silent process group poll exception with debug log (utks…

7026162

…h1#1542) Co-authored-by: tmdeveloper007 <[email protected]>

test : add parser unit tests for ssh_runner plugin (utksh1#1541)

f250fc0

Co-authored-by: tmdeveloper007 <[email protected]>

test : add parser unit tests for sqlmap plugin (utksh1#1540)

78f6727

Co-authored-by: tmdeveloper007 <[email protected]>

test : add parser unit tests for sqli_checker plugin (utksh1#1539)

44c8e65

Co-authored-by: tmdeveloper007 <[email protected]>

test : add parser unit tests for secret_scanner plugin (utksh1#1538)

6ce0fcb

Co-authored-by: tmdeveloper007 <[email protected]>

test : add parser unit tests for scapy_recon plugin (utksh1#1537)

6e58a6d

Co-authored-by: tmdeveloper007 <[email protected]>

Resolves issue-utksh1#1430 (utksh1#1530)

0f0fa8a

Resolves issue-utksh1#1428 (utksh1#1528)

9af5fbf

tests(metasploit): add parser and metadata unit tests utksh1#1427 (ut…

8441e05

…ksh1#1527) * Resolves issue-utksh1#1427 * Removes white spaces.

Resolves issue-utksh1#1426 (utksh1#1526)

a522725

Resolves issue-utksh1#1429 (utksh1#1529)

93d2b89

ci: ignore local virtualenv directories (utksh1#1510)

8ec56fc

Resolves issue-utksh1#1423 (utksh1#1511)

db9aa8c

Fix utksh1#1170: Bottom section UI overlap/misalignment on Dashboard …

5681e24

…(mobile view) (utksh1#1513)

Fix utksh1#1488: Missing Rate Limiters on Management Endpoints (utksh…

1606c2c

…1#1514)

Fix utksh1#1491: Unhandled Type Conversion and Logic Errors in Workfl…

00e5bd2

…ows (utksh1#1515)

Fix utksh1#1490: Missing Validation for JSON Payload Contents (utksh1…

8b35203

…#1516)

[PLUGINS] Add parser unit tests for httpx plugin utksh1#1425 (utksh1#…

060d620

…1520) * Resolves issue-utksh1#1425 * Removed white spaces.

docs: update browser auth session flow (utksh1#1555)

9edf153

Co-authored-by: Tomeshwari-02 <[email protected]>

test(secret_scanner): add parser fallback coverage (utksh1#1556)

846d190

feat(validation): introduce string length constraints on policy, prof…

604e4e5

…ile, and workflow endpoints (utksh1#1557)

test: add unit tests for executor_target_helpers.extract_target (utks…

5cb0dd4

…h1#1563) Co-authored-by: tmdeveloper007 <[email protected]>

test: add unit tests for wpscan plugin parser helpers (utksh1#1564)

09c55a7

Co-authored-by: tmdeveloper007 <[email protected]>

Contributor and others added 4 commits July 21, 2026 16:45

Merge pull request utksh1#2033 from NaitikVerma6776/cursor/utc-timezo…

caf6b04

…ne-standardize-9bb6 fix(backend): standardize timezone handling to UTC ISO-8601

Merge pull request utksh1#2055 from utksh1/fix/1748-mandatory-denylis…

14a3312

…t-metadata-ssrf Fix utksh1#1748: make cloud-metadata/private-range denylist non-overridable

Merge pull request utksh1#2025 from utksh1/fix-saved-views-1743

ef4efd3

Fix: add auth and owner isolation to saved views API (closes utksh1#1743)

utksh1 added level:intermediate 35 pts difficulty label for moderate contributor PRs type:bug Bug fix work category bonus label area:frontend Frontend React/UI work labels Jul 24, 2026

utksh1 requested changes Jul 24, 2026

View reviewed changes

Khanvilkarshravani27 added 2 commits July 24, 2026 15:10

Khanvilkarshravani27 force-pushed the fix-infinite-scroll-total-items branch from 5de7667 to b23f7e0 Compare July 25, 2026 08:39

Merge branch 'main' into fix-infinite-scroll-total-items

4ddb571

Khanvilkarshravani27 requested a review from utksh1 July 25, 2026 08:41

shravanithouta108 and others added 13 commits July 30, 2026 11:50

ci: Add Dependabot configuration for automated dependency updates (ut…

6086a79

…ksh1#2390)

Fix risk scoring defaults (utksh1#2393)

d5cf856

* Fix risk scoring defaults * Update risk scoring tests

ci: Pin GitHub Actions to immutable commit SHAs (utksh1#2402)

5dabf25

Limit webhook response buffering (utksh1#2416)

d508c40

Add retry support for notification delivery (utksh1#2360)

7239e61

* Add retry support for notification delivery * Remove trailing whitespace

docs: document raw scan output retention and cleanup (utksh1#2351)

837bdce

Co-authored-by: Soujanya S H <[email protected]>

Merge branch 'main' into fix-infinite-scroll-total-items

2ce8914

utksh1 closed this Aug 15, 2026

utksh1 force-pushed the main branch from 933bf67 to 45aac5c Compare August 15, 2026 18:38

Navigation Menu

Fix infinite scroll total items - #2069

Fix infinite scroll total items#2069
Khanvilkarshravani27 wants to merge 954 commits into
utksh1:mainfrom
Khanvilkarshravani27:fix-infinite-scroll-total-items

Khanvilkarshravani27 commented Jul 23, 2026 •

edited

Loading

Uh oh!

utksh1 left a comment

Uh oh!

utksh1 left a comment

Uh oh!

Khanvilkarshravani27 commented Jul 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

Khanvilkarshravani27 commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Type of Change

How Has This Been Tested?

Checklist

Uh oh!

utksh1 left a comment

Choose a reason for hiding this comment

Uh oh!

utksh1 left a comment

Choose a reason for hiding this comment

Uh oh!

Khanvilkarshravani27 commented Jul 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Khanvilkarshravani27 commented Jul 23, 2026 •

edited

Loading