plugin_validator skips placeholder validation inside --if tokens#2009
Open
karrisanthoshigayatri wants to merge 2 commits into
Open
plugin_validator skips placeholder validation inside --if tokens#2009karrisanthoshigayatri wants to merge 2 commits into
karrisanthoshigayatri wants to merge 2 commits into
Conversation
utksh1
requested changes
Jul 13, 2026
utksh1
left a comment
Owner
There was a problem hiding this comment.
Thanks for tightening placeholder validation inside --if tokens. Please add regression tests for the new parsing path before merge: cover a valid placeholder in a then/else segment, an unknown placeholder in a then/else segment, and a token with multiple colon-separated pieces so we know the parser does not miss or misread placeholders. The current PR changes validator behavior but has no test coverage for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1801
Description
Related Issues
Type of Change
How Has This Been Tested?
Checklist