Skip to content

plugin_validator skips placeholder validation inside --if tokens#2009

Open
karrisanthoshigayatri wants to merge 2 commits into
utksh1:mainfrom
karrisanthoshigayatri:main
Open

plugin_validator skips placeholder validation inside --if tokens#2009
karrisanthoshigayatri wants to merge 2 commits into
utksh1:mainfrom
karrisanthoshigayatri:main

Conversation

@karrisanthoshigayatri

Copy link
Copy Markdown
Contributor

#1801

Description

Related Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

@utksh1 utksh1 added level:beginner 20 pts difficulty label for small beginner-friendly PRs type:bug Bug fix work category bonus label area:backend Backend API, database, or service work labels Jul 13, 2026

@utksh1 utksh1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tightening placeholder validation inside --if tokens. Please add regression tests for the new parsing path before merge: cover a valid placeholder in a then/else segment, an unknown placeholder in a then/else segment, and a token with multiple colon-separated pieces so we know the parser does not miss or misread placeholders. The current PR changes validator behavior but has no test coverage for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend Backend API, database, or service work level:beginner 20 pts difficulty label for small beginner-friendly PRs type:bug Bug fix work category bonus label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants