test: Add Background component rendering contract tests-#1414#1716
test: Add Background component rendering contract tests-#1414#1716Rakshak05 wants to merge 5 commits into
Conversation
utksh1
left a comment
There was a problem hiding this comment.
The frontend accessibility/rendering tests are reasonable, but this PR includes unrelated backend parser_sandbox churn.\n\n1. Remove the unrelated backend/test changes.\n2. Keep this PR focused on the Background component behavior and accessibility contract only.\n\nOnce the scope is narrowed, this should be straightforward to re-review.
utksh1
left a comment
There was a problem hiding this comment.
Thanks for narrowing the frontend test scope, but this still includes unrelated changes to .github/workflows/ci.yml. Please remove the CI workflow edits and keep this PR focused on the Background component accessibility/rendering contract only.
utksh1
left a comment
There was a problem hiding this comment.
The CI workflow change is gone, but the latest push now includes an unrelated backend edit to testing/backend/unit/test_tls_verification.py. Please remove that TLS test fix and keep this PR limited to Background.tsx plus its frontend component tests. The TLS regression belongs in its own focused PR.
Description
This Pull Request introduces unit tests for the shared visual
Backgroundcomponent to ensure its rendering and accessibility properties remain correct and robust.Specifically, the following changes were made:
Background.tsxto includearia-hidden="true", ensuring this purely decorative visual layer is hidden from assistive technologies.Background.test.tsxcontaining contract tests that verify the component renders without crashing, correctly applies custom state modifiers (active,error,idle), asserts the decorative layers are hidden, and remains independent of animation timing.Related Issues
Closes #1414
Type of Change
How Has This Been Tested?
We validated these changes by running the unit tests using Vitest in the
frontenddirectory:```powershell
npx vitest run testing/unit/components/Background.test.tsxChecklist