Fix carousel focus ring: hug the card and update without scroll delay#1692
Merged
utkarshdalal merged 1 commit intoJul 12, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe changes adjust library UI focus behavior by requesting carousel focus before scrolling and moving the grid card focus ring from the outer wrapper onto the card. ChangesLibrary focus behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
b0e10f1 to
3f33ed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two issues with the animated focus ring on library game cards in carousel mode:
GridViewCard's outer box. In the carousel that box is fill-sized to the item slot while the visibleCardsizes itself viafillMaxWidth().aspectRatio(2/3), so the ring didn't line up with the card. It's now drawn on theCarditself, so it hugs the visible bounds in every layout (grid unchanged).navigateCarousel,requestFocus()ran only after the suspendinganimateScrollToItem()completed, so the ring waited out the whole scroll animation before moving. Focus is now requested first (the ring follows immediately) and the scroll animates afterwards.Recording
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Fixes the carousel focus ring so it hugs the visible card and updates immediately when changing selection, without waiting for scroll and avoiding focus exceptions.
Cardinstead of the outer slot so it aligns with the card’s 2:3 bounds; grid unchanged.IllegalStateException.Written for commit 3f33ed6. Summary will update on new commits.
Summary by CodeRabbit
Summary by CodeRabbit