fix: Refactor AppScreenContent optionsMenu parameter to List

[joshuatam]

Description

Updates the optionsMenu parameter from vararg AppMenuOption to List to resolve a build crash issue, particularly noticeable during clean builds.

Recording

N/A

Type of Change

• Bug fix
• Performance / stability improvement
• Compatibility improvements
• Other (requires prior approval)

Checklist

• If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
• This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
• I have attached a recording of the change.
• I have read and agree to the contribution guidelines in CONTRIBUTING.md.

---

Summary by cubic

Refactored AppScreenContent to accept optionsMenu as List<AppMenuOption> instead of vararg to fix a clean-build crash and simplify call sites. Updated LibraryAppScreen and BaseAppScreen to pass lists directly; no functional changes.

^{Written for commit e127020. Summary will update on new commits.}

Summary by CodeRabbit

• Refactor
  • Streamlined how screen menu options are passed between app screens.
  • Preserved existing menu behavior while simplifying internal option handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 55cc5db2-43a2-4b36-8f8f-85a9f37affad

📥 Commits

Reviewing files that changed from the base of the PR and between 7cc9f93 and e127020.

📒 Files selected for processing (2)

• app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt
• app/src/main/java/app/gamenative/ui/screen/library/appscreen/BaseAppScreen.kt

---

📝 Walkthrough

Walkthrough

Changes

Options menu list wiring

Layer / File(s)	Summary
List-based options menu contract and call sites app/src/main/java/app/gamenative/ui/screen/library/LibraryAppScreen.kt, app/src/main/java/app/gamenative/ui/screen/library/appscreen/BaseAppScreen.kt	AppScreenContent now accepts List<AppMenuOption>, and preview and base screen callers pass lists without converting them to arrays.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

• utkarshdalal/GameNative#299: Refactors the app screen options menu flow to build and return a List<AppMenuOption>.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: refactoring AppScreenContent's optionsMenu parameter to a List.
Description check	✅ Passed	The description includes the required sections and gives clear context for the change, with only the recording marked N/A.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cubic-dev-ai]

No issues found across 2 files

_{Re-trigger cubic}