fix: Show "Opening container" on loading screen when opening a container instead of saying "Launching Game"#1563
fix: Show "Opening container" on loading screen when opening a container instead of saying "Launching Game"#1563Monkeygamer2010 wants to merge 14 commits into
Conversation
…nstead of saying "Launching Game"
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughBoot splash messaging is updated across launch and container setup flows to use ChangesBoot Splash Context-Aware and Localized Messaging
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Monkeygamer2010
changed the title
Monkeygamer2010
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/app/gamenative/ui/model/MainViewModel.kt`:
- Around line 452-455: The two separate state updates (setShowBootingSplash and
setBootingSplashText) can cause a one-frame flash of stale text; change the code
to perform a single atomic state update on _state (e.g., use _state.update {
it.copy(showBootingSplash = true, bootingSplashText = if (it.bootToContainer)
"Opening container..." else "Launching game...") }) so both visibility and text
change together; update the call site where setShowBootingSplash and
setBootingSplashText are invoked to use this single _state.update to avoid
intermediate state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 42c871ea-e786-4a0c-8f43-ebead076f88b
📒 Files selected for processing (2)
app/src/main/java/app/gamenative/ui/model/MainViewModel.ktapp/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
Refactor booting splash logic to improve clarity and prevent flickering.
✅ Action performedFull review finished. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
reverted the neutral "Booting" before "Launching Game" or "Opening container"
|
@cubic-dev-ai review this latest commit |
@Monkeygamer2010 I have started the AI code review. It will take a few minutes to complete. |
|
Tested further everything looks good |
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
in order to replace hardcoded strings with string resources.
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt`:
- Around line 3243-3247: The PluviaApp.events.emit calls with
AndroidEvent.SetBootingSplashText contain hardcoded English strings ("Installing
prerequisites...", "Opening container...", "Launching game...") which bypass
localization. Replace these hardcoded strings with string resources (e.g.,
getString(R.string.boot_splash_prerequisites),
getString(R.string.boot_splash_opening_container),
getString(R.string.boot_splash_launching_game)) in both locations mentioned (the
initial block around line 3243-3247 and the second block around 3345-3351).
Define the corresponding string resource entries in the strings.xml file to
ensure consistent localization across the app like the MainViewModel and DRM
flows already do.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 277913fc-01ea-4403-846c-81f0acdb36b2
📒 Files selected for processing (3)
app/src/main/java/app/gamenative/ui/model/MainViewModel.ktapp/src/main/java/app/gamenative/ui/screen/xserver/XAudioUtils.ktapp/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
Replaced pre-install command checks with a pre-unpack setup for the guest program launcher.
✅ Action performedFull review finished. |
✅ Action performedComments resolved. Approval is disabled; enable |
|
@Monkeygamer2010 have left some comments |
…viewModel.state.value Fixes a bug where if a cloud conflict or any sort of dialogue pop up happens when "open container" is pressed, the splash text will return to "Launching Game" instead of "Opening container". And read the latest state from directly ViewModel instead of waiting for recomposition.
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/main/java/app/gamenative/ui/PluviaMain.kt (1)
895-906: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winCritical syntax error: duplicate parameter and closing parenthesis.
Lines 903-904 correctly close the
preLaunchAppcall with thebootToContainerparameter. Lines 905-906 duplicate this, creating a syntax error that will prevent compilation.🐛 Proposed fix
onSuccess = viewModel::launchApp, isOffline = viewModel.isOffline.value, bootToContainer = state.bootToContainer, ) - bootToContainer = state.bootToContainer, - ) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/java/app/gamenative/ui/PluviaMain.kt` around lines 895 - 906, The preLaunchApp function call has duplicate parameters and closing parenthesis creating a syntax error. The bootToContainer parameter and its closing parenthesis appear twice - once correctly on lines 903-904, and then again duplicated on lines 905-906. Remove the duplicate bootToContainer parameter assignment and the extra closing parenthesis that appear after the initial function call closes, keeping only the first instance of the parameter and closing parenthesis.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@app/src/main/java/app/gamenative/ui/PluviaMain.kt`:
- Around line 895-906: The preLaunchApp function call has duplicate parameters
and closing parenthesis creating a syntax error. The bootToContainer parameter
and its closing parenthesis appear twice - once correctly on lines 903-904, and
then again duplicated on lines 905-906. Remove the duplicate bootToContainer
parameter assignment and the extra closing parenthesis that appear after the
initial function call closes, keeping only the first instance of the parameter
and closing parenthesis.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a79ec498-cbf7-47b8-8d4c-3e27c472d755
📒 Files selected for processing (2)
app/src/main/java/app/gamenative/ui/PluviaMain.ktapp/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
🚧 Files skipped from review as they are similar to previous changes (1)
- app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
|
tested again with new commits and everything works good and cloud save conflicts wont make "Open container" have "Launching game" on its splash screen. |
@Monkeygamer2010 I have started the AI code review. It will take a few minutes to complete. |
|
(∩｀-´)⊃━☆ﾟ.*・｡ﾟ ✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/main/java/app/gamenative/ui/PluviaMain.kt (1)
860-870: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winPropagate
bootToContainerin the remaining re-launch dialog paths.
DialogType.SYNC_IN_PROGRESSandDialogType.APP_SESSION_ACTIVEstill callpreLaunchApp(...)withoutbootToContainer, so they fall back tofalseand can regress the Open Container flow/message on retry paths.Proposed fix
preLaunchApp( context = context, appId = state.launchedAppId, skipCloudSync = true, setLoadingDialogVisible = viewModel::setLoadingDialogVisible, setLoadingProgress = viewModel::setLoadingDialogProgress, setLoadingMessage = viewModel::setLoadingDialogMessage, setMessageDialogState = setMessageDialogState, onSuccess = viewModel::launchApp, isOffline = viewModel.isOffline.value, + bootToContainer = state.bootToContainer, ) ... preLaunchApp( context = context, appId = state.launchedAppId, ignorePendingOperations = true, setLoadingDialogVisible = viewModel::setLoadingDialogVisible, setLoadingProgress = viewModel::setLoadingDialogProgress, setLoadingMessage = viewModel::setLoadingDialogMessage, setMessageDialogState = setMessageDialogState, onSuccess = viewModel::launchApp, + bootToContainer = state.bootToContainer, )Also applies to: 917-926
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/java/app/gamenative/ui/PluviaMain.kt` around lines 860 - 870, The re-launch dialog paths in PluviaMain.kt still call preLaunchApp without passing bootToContainer, so the retry flow defaults to false and can break the Open Container behavior. Update the DialogType.SYNC_IN_PROGRESS and DialogType.APP_SESSION_ACTIVE branches to forward the same bootToContainer value used elsewhere when invoking preLaunchApp, matching the existing launchApp/preLaunchApp flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/app/gamenative/ui/PluviaMain.kt`:
- Around line 951-954: There is an extra unmatched closing parenthesis after the
preLaunchApp call in PluviaMain.kt, which breaks Kotlin syntax and compilation.
Remove the stray “)” so the surrounding if/launch block in the preLaunchApp(...)
section closes with the correct number of parentheses, and verify the nearby
bootToContainer assignment and method call nesting remain balanced.
---
Outside diff comments:
In `@app/src/main/java/app/gamenative/ui/PluviaMain.kt`:
- Around line 860-870: The re-launch dialog paths in PluviaMain.kt still call
preLaunchApp without passing bootToContainer, so the retry flow defaults to
false and can break the Open Container behavior. Update the
DialogType.SYNC_IN_PROGRESS and DialogType.APP_SESSION_ACTIVE branches to
forward the same bootToContainer value used elsewhere when invoking
preLaunchApp, matching the existing launchApp/preLaunchApp flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1aee6dfe-28a6-463d-be49-01761692392b
📒 Files selected for processing (4)
app/src/main/java/app/gamenative/ui/PluviaMain.ktapp/src/main/java/app/gamenative/ui/model/MainViewModel.ktapp/src/main/java/app/gamenative/ui/screen/xserver/XAudioUtils.ktapp/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
|
You're iterating quickly on this pull request. To help protect your rate limits, cubic has paused automatic reviews on new pushes for now—when you're ready for another review, comment |
2 participants
Description
Previously when opening a container for any game would give a loading screen saying "Launching game" which doesn't correspond to what is actually happening, this changes the loading screen to instead say "Opening container" ONLY when the "Open Container" option is pressed, this has no effect on any other loading screen.
Recording
Screen_Recording_20260609_220114_GameNative.zip
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Show “Opening container…” when using Open Container and set the correct splash text immediately to prevent flicker. Dialog/setup flows preserve the right message, use
R.string, and remove a duplicatebootToContainerparameter.showBootingSplashandbootingSplashTextimmediately viaR.stringbased onbootToContainer.bootToContainerthrough all dialog retries, reads the latest ViewModel state for XServerScreen to avoid reversion after prompts, and removes a duplicatebootToContainerparam.R.stringfor prerequisites, DRM, and per-executable DRM progress; restores the correct message instead of a neutral “Booting…”.R.stringfor “Extracting XAudio DLLs…”.Written for commit 45be9a4. Summary will update on new commits.
Summary by CodeRabbit