fix: add canonical ls subcommand to image and container groups#27
Merged
Conversation
Implement the previously-dead image list flags so `image ls` reaches parity with `container ls`: - --filter (reference, label), --format, --no-trunc now apply. - --all/--digests/--tree stay accepted no-ops (no backing data). Fix container --latest/--last to include all states regardless of --all, as Docker does and as the flag help already promises. Extract the filter/format logic into pure, unit-tested helpers.
Owner
|
Thanks a lot for this, @jahirvidrio! 🙌 Spot-on fix for the I pushed a small follow-up on top:
Flags with no backing data ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
Adds
lsas the canonical list subcommand in theimageandcontainergroups,keeping
images/psas visible aliases so nothing breaks.What changed
image/containergroups:lsis now the canonical subcommand and group default;images/psstay as visible aliases.ImageListOptions/ContainerListOptions(@OptionGroup), so the grouplsand the top-level shortcut share one source of truth.mocker images/mocker psunchanged (MockerCLI.swiftuntouched) — they remain the Docker top-level shortcuts.