Test/proceed test#377
Open
celikerde wants to merge 8 commits into
Open
Conversation
- Implement tests to verify deletion of status file on reset. - Ensure route statuses are cleared and treated as inactive after reset. - Confirm no failure occurs when resetting without an existing status file.
- Introduced tests for AssignmentStatus, PaymentStatus, Permission, ProcessStatus, and RevisionStatus enums. - Verified expected values, labels, colors, icons, and additional methods for each enum. - Ensured comprehensive coverage of enum functionalities to maintain code integrity.
- Introduced tests for ModularousUserRegistered, ModularousUserRegistering, ModularousUserVerification, and VerifiedEmailRegister events. - Verified constructor behavior, request handling, and OAuth status for each event. - Ensured event instances are independent and utilize the SerializesModels trait for model serialization.
- Introduced tests for the authentication handler to verify behavior when a user is already authenticated, when authentication throws an exception, and when session lookup fails. - Added tests for the ValidationException class to ensure correct JSON response formatting and error handling. - Ensured comprehensive coverage of both the handler and exception functionalities to maintain code integrity.
- Introduced comprehensive tests for the HasPriceableMutators trait, ensuring correct behavior of price-related attributes and methods. - Verified that the trait is properly used by the model and that default values are returned when no base price is set. - Included tests for formatted attributes to ensure they utilize the PriceService correctly with currency formatting. - Ensured coverage of scenarios involving discounts and VAT calculations to maintain code integrity.
- Introduced tests for the CacheObserver to ensure cache invalidation occurs correctly on model events: created, updated, deleted, restored, and forceDeleted. - Verified that caching behavior is properly handled when caching is enabled for the model's module. - Ensured comprehensive coverage of cache invalidation scenarios to maintain code integrity.
- Introduced comprehensive tests for the PriceableObserver to validate the correct handling of price calculations, including raw amounts and VAT amounts based on configuration settings for including or excluding VAT. - Verified behavior for various scenarios, including zero price values and discount percentages, ensuring accurate attribute management during model events. - Ensured thorough coverage of the saving, retrieved, and replicating methods to maintain code integrity.
oguzhanbukcuoglu
requested changes
Jun 27, 2026
oguzhanbukcuoglu
left a comment
oguzhanbukcuoglu
left a comment
Collaborator
There was a problem hiding this comment.
You recreated some tests, go over tests/Models folder. There are also same test classes under the folder.
Collaborator
Author
I will check and fix it within today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Types of changes
Description
Related Issue