fix(integration): Several fixes to get tests to pass#412
Open
craciunoiuc wants to merge 7 commits into
Open
Conversation
Signed-off-by: Cezar Craciunoiu <[email protected]>
Signed-off-by: Cezar Craciunoiu <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the integration-test harness and CI workflow configuration to address recent failures and improve compatibility across different test servers/environments.
Changes:
- Centralizes test-server selection logic via a new
GetTestServerhelper and updates server-based skipping accordingly. - Updates instance integration tests to match current
instance inspectoutput and adds a propagation delay intended for prod nodes. - Tweaks the GitHub Actions integration-test configuration generation (including enabling
insecureand switchingUNIKRAFT_ORGsourcing).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
internal/integration/skip.go |
Uses the new helper to decide when to skip tests on unsupported servers. |
internal/integration/config.go |
Adds GetTestServer helper for test-server support detection. |
cmd/unikraft/integration/instance_test.go |
Updates output assertions and adds a prod-propagation delay. |
.github/workflows/test.yaml |
Updates generated config for integration tests and CI env wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Cezar Craciunoiu <[email protected]>
Signed-off-by: Cezar Craciunoiu <[email protected]>
895e9e3 to
8b6ca77
Compare
Signed-off-by: Cezar Craciunoiu <[email protected]>
Signed-off-by: Cezar Craciunoiu <[email protected]>
Signed-off-by: Cezar Craciunoiu <[email protected]>
51edfac to
ce291db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.