Skip to content

fix(integration): Several fixes to get tests to pass#412

Open
craciunoiuc wants to merge 7 commits into
prod-stagingfrom
craciunoiuc/fix-tests
Open

fix(integration): Several fixes to get tests to pass#412
craciunoiuc wants to merge 7 commits into
prod-stagingfrom
craciunoiuc/fix-tests

Conversation

@craciunoiuc

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the integration-test harness and CI workflow configuration to address recent failures and improve compatibility across different test servers/environments.

Changes:

  • Centralizes test-server selection logic via a new GetTestServer helper and updates server-based skipping accordingly.
  • Updates instance integration tests to match current instance inspect output and adds a propagation delay intended for prod nodes.
  • Tweaks the GitHub Actions integration-test configuration generation (including enabling insecure and switching UNIKRAFT_ORG sourcing).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
internal/integration/skip.go Uses the new helper to decide when to skip tests on unsupported servers.
internal/integration/config.go Adds GetTestServer helper for test-server support detection.
cmd/unikraft/integration/instance_test.go Updates output assertions and adds a prod-propagation delay.
.github/workflows/test.yaml Updates generated config for integration tests and CI env wiring.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/unikraft/integration/instance_test.go
Comment thread cmd/unikraft/integration/instance_test.go
Comment thread internal/integration/config.go Outdated
Comment thread .github/workflows/test.yaml
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/fix-tests branch 4 times, most recently from 895e9e3 to 8b6ca77 Compare July 8, 2026 11:37

@jedevc jedevc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still failing 🤔

Comment thread cmd/unikraft/integration/instance_test.go Outdated
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/fix-tests branch from 51edfac to ce291db Compare July 8, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants