feat: Implement nested JSON in api subcommand by khatibomar · Pull Request #389 · unikraft-cloud/cli

khatibomar · 2026-06-27T18:31:22Z

Implement nested JSON in api subcommand
closes Use nested JSON syntax in unikraft api #369

Signed-off-by: ayn [email protected]

Signed-off-by: ayn <[email protected]>

khatibomar · 2026-06-28T22:52:54Z

+		return json.Unmarshal([]byte("{}"), &v.Value)
+	}
+	var items []string
+	for line := range strings.SplitSeq(s, "\n") {


currently it expects that input is being seperated with a \n for each element.

Need some thinking.

See above, we can allow multiple Unmarshals.

jedevc

Sorry for my slowness! I finally got round to it (chaos week sorry) - just some early feedback, I saw this is still in draft. But it's so neat!

Much love for this new Jason type 🎉

jedevc · 2026-07-03T15:37:03Z

+	var bodyData jason.Jason[map[string]any]
+	data := []byte(strings.Join(items, "\n"))
+	if err := jason.Unmarshal(data, &bodyData); err != nil {
+		return nil, err
+	}
+	return jason.Marshal(bodyData)


Instead of this, you could just loop over all items, and unmarshal them one-by-one.

So essentially:

tags = []

Unmarshal("tags[]=production")

tags = [production]

Unmarshal("tags[]=eu-west")

tags = [production, eu-west]

the way I am thinking of it, is that, a valid JSON is [....] or {} with proper syntax that have proper key value.

On other hand a valid nested-JSON is list of key=value pairs or valid JSON

so jason.Unmarshal somehow should take all of these and parse them as a one unit, that was my vision behind that Unmarshaling.

What we can do is keep parser to expect a \n to seperate them with clear comment about expected input, but in api.go we pass items one by one instead of joining them which also results in a valid end result.
Another thing we can do is make the parser bit smarter about spaces, but that ofc will come with complexity cost depends if spaces are allowed or not. For example tags [] = production is this valid nested-JSON or not, based on that the parsing becomes complex.

jedevc · 2026-07-03T15:37:54Z

+	}
+
+	for _, arg := range c.Args {
+		if strings.HasPrefix(arg, "@") {


We have a check here and also in readBodyItems. It's probably worth consolidating them, ideally if we could just have all the parsing logic in one place, like readBodyItems.

jedevc · 2026-07-03T15:39:41Z

This is so neat, I quite like this.

Any reason for naming it Jason? It's cute.

My only real big comment here is that we should split the package down. jason.go contains top-level public interfaces, while the parsing goes in parse.go, debug goes in debug.go, etc.

I first named it nested, but it's not only nested, it's nested-JSON + JSON together.
Couldn't find a better name, jason was closest to my head because of a meme stuck in my head from youtube I guess. Prob Primeagen can't remember.

JavaScript Advanced Object Notation 🥼

Aha, I love that 🎉 Maybe just make a note of it in the file, then it's all good 😁

jedevc · 2026-07-03T15:40:54Z

+
+// VisualizeItems is a convenience function that parses the given items
+// and returns a tree visualization of the result.
+func VisualizeItems(items []string) (string, error) {


Probably best to just have Visualize.

jedevc · 2026-07-03T15:43:03Z

+	case []any:
+		b.WriteString("[\n")
+		for i, elem := range val {
+			b.WriteString(indent)


You can use fmt.Fprintf(b, "%s [%d] =, indent, i)` to simplify some of this string building.

jedevc · 2026-07-03T15:43:47Z

+// DebugTree returns a detailed multi-line breakdown showing how each
+// input item is parsed and where it lands in the final tree. This is
+// useful for understanding the parsing of complex nested expressions.
+//
+// The output shows every item grouped by its top-level key, with parsed
+// path segments and the final assigned value.
+func DebugTree(items []string) (string, error) {


Can make this debugTree to keep it internal?

jedevc · 2026-07-03T15:44:33Z

+		return json.Unmarshal([]byte("{}"), &v.Value)
+	}
+	var items []string
+	for line := range strings.SplitSeq(s, "\n") {


See above, we can allow multiple Unmarshals.

jedevc · 2026-07-03T15:45:28Z

+// or more bracketed segments. After the path an '=' or ':=' separates the
+// value. If the item is a valid JSON object or array it is returned as a
+// raw value with an empty path so callers can merge it at the root.
+func parseItem(item string) (parsedItem, error) {


Note to self: read and review this code in a little depth.

jedevc · 2026-07-03T15:46:56Z

+	assert.Equal(t, expected, output)
+}
+
+func ExampleDebugTree() {


Fun little idea. Because this writing a new (fairly fiddly) parser, what do you think about writing a little fuzzer to search for issues? https://go.dev/doc/security/fuzz/

Then just run it for an hour or so, and see if it can find any crashes 🎉 (we've had some really annoying and difficult crashes in the last week, so hardening things to avoid needing to debug broken stuff later is very nice).

Signed-off-by: ayn <[email protected]>

feat: Implement nested JSON in api subcommand

27691a9

Signed-off-by: ayn <[email protected]>

khatibomar mentioned this pull request Jun 27, 2026

Use nested JSON syntax in unikraft api #369

Open

fix: Lint in CI

25ad53b

Signed-off-by: ayn <[email protected]>

khatibomar force-pushed the feat/nested-JSON branch from 59f246b to 25ad53b Compare June 27, 2026 18:42

refactor: Rename package name from nested to JASON

8f29457

Signed-off-by: ayn <[email protected]>

khatibomar force-pushed the feat/nested-JSON branch from 32e293a to ed7471b Compare June 28, 2026 20:57

feat: Support mix of JSON and nested-JSON in JASON

024eb4d

Signed-off-by: ayn <[email protected]>

khatibomar force-pushed the feat/nested-JSON branch from ed7471b to 024eb4d Compare June 28, 2026 21:03

fix: JASON un/marshal methods

291c1ca

Signed-off-by: ayn <[email protected]>

khatibomar force-pushed the feat/nested-JSON branch from 2ca9dc4 to 291c1ca Compare June 28, 2026 22:01

fix: Update test to reflect new API change

97e9b12

Signed-off-by: ayn <[email protected]>

khatibomar commented Jun 28, 2026

View reviewed changes

jedevc reviewed Jul 3, 2026

View reviewed changes

refactor: Split jason into multiple files

5cecff2

Signed-off-by: ayn <[email protected]>

khatibomar force-pushed the feat/nested-JSON branch from 452b5e0 to 5cecff2 Compare July 4, 2026 22:51

khatibomar added 3 commits July 5, 2026 01:51

refactor: Use Fprintf instead of b.WriteString

8586bcf

Signed-off-by: ayn <[email protected]>

refactor: remove redundant check in parsing @ in api cmd

64442de

Signed-off-by: ayn <[email protected]>

fix: Jason large and out of bound array cases

8e84b1f

Signed-off-by: ayn <[email protected]>

khatibomar force-pushed the feat/nested-JSON branch from 5f593fa to 8e84b1f Compare July 6, 2026 22:44

Uh oh!

Conversation

khatibomar commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jedevc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khatibomar Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

khatibomar commented Jun 27, 2026 •

edited

Loading

khatibomar Jul 4, 2026 •

edited

Loading