feat: Add instance autokill#355
Open
jedevc wants to merge 1 commit into
Open
Conversation
craciunoiuc
requested changes
Jun 5, 2026
| assert.Regexp(t, `autokill:`, out) | ||
| assert.Regexp(t, `time:\s+10s`, out) | ||
| assert.Regexp(t, `num-requests:\s+100`, out) | ||
|
|
Contributor
There was a problem hiding this comment.
Can we make it auto-kill on 1 request and then do an httpget on it and check again if it dissapeared?
Member
Author
There was a problem hiding this comment.
Hm. This feels like something for the QA team.
We test that the property can be created + edited + viewed - so the CLI is working correctly. We should avoid testing that the platform behavior is correct (as much as possible in these tests).
More complex tests make sense in some scenarios... but I think this one is a bit over-the-line. If you think otherwise, I can hack something together though.
Contributor
There was a problem hiding this comment.
I'm fine either way, but I don't think that the functionality tested is that complex 🙏
I'll let you decide
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
jedevc/instance-autokill
branch
from
bf86d2b to
ee13210
Compare
nurof3n
reviewed
Jun 5, 2026
|
|
||
| ScaleToZero InstanceScaleToZero `group:"flag-edit" shortcut:"scale-to-zero" help:"Scale-to-zero options.\n policy: on | idle | off\n cooldown-time: cooldown in ms before scaling to zero\n notify-time: notification time in ms before scaling to zero\n stateful: true | false" placeholder:"<key>=<value>" example:"on,policy=on\\,cooldown-time=300,policy=on\\,stateful=true\\,cooldown-time=500\\,notify-time=100"` | ||
|
|
||
| Autokill InstanceAutokill `group:"flag-edit" shortcut:"autokill" help:"Autokill options.\n time: time after the instance stops before it is deleted\n num-requests: max requests before the instance is deleted" placeholder:"<key>=<value>" example:"time=5s,num-requests=100,time=5s\\,num-requests=100"` |
Contributor
There was a problem hiding this comment.
Suggested change
| Autokill InstanceAutokill `group:"flag-edit" shortcut:"autokill" help:"Autokill options.\n time: time after the instance stops before it is deleted\n num-requests: max requests before the instance is deleted" placeholder:"<key>=<value>" example:"time=5s,num-requests=100,time=5s\\,num-requests=100"` | |
| Autokill InstanceAutokill `group:"flag-edit" shortcut:"autokill" help:"Autokill options.\n time: time after the instance stops before it is deleted\n num-requests: max requests before the instance is deleted" placeholder:"<key>=<value>" example:"time=5s,num-requests=100\\,num-requests=100"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: