refactor(integration): Build busybox image only once#350
Draft
craciunoiuc wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors integration tests to reuse a single shared busybox-based image across multiple test cases, reducing repeated unikraft build operations and speeding up the integration test suite.
Changes:
- Added a shared image builder (
BuildSharedBusyboxImage) that builds a single busybox image containing multiple test entrypoint scripts. - Updated integration build tests to run against the shared image and select behavior via
--args+ pre-baked entrypoints. - Removed per-test busybox image build contexts that were previously recreated for ROM-related tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/integration/image.go | Introduces shared busybox image build logic and baked-in entrypoint scripts for reuse across tests. |
| cmd/unikraft/integration/build_test.go | Switches ROM/custom-run tests to use the shared busybox image instead of building a new busybox image per subtest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
craciunoiuc
force-pushed
the
craciunoiuc/build-busybox-just-once
branch
2 times, most recently
from
d00564c to
9415f75
Compare
Like this we build the instance only once instead of multiple times cutting down significantly on builds. Signed-off-by: Cezar Craciunoiu <[email protected]>
craciunoiuc
force-pushed
the
craciunoiuc/build-busybox-just-once
branch
from
9415f75 to
cdb1caf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like this we build the instance only once instead of multiple times cutting down significantly on builds.