feat(internal/cmd): Add 'instance tunnel' command#248
Open
craciunoiuc wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new unikraft instance tunnel subcommand intended to forward a local port to a non-public instance via an intermediate TLS tunnel service, enabling testing scenarios that require internal VM traffic.
Changes:
- Adds
InstancesTunnelCmdto the instances command group. - Implements target parsing, instance/IP resolution, tunnel-proxy instance creation, and local-to-remote relaying over TLS.
- Adds control-channel heartbeats to keep the tunnel service connection alive.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
2 times, most recently
from
49d2539 to
8ae136d
Compare
jedevc
reviewed
Apr 7, 2026
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
8ae136d to
5e8f3e5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I need to fix these + do one more pass so no rush |
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
5e8f3e5 to
b8e8437
Compare
Contributor
Author
|
Should be as decent as it gets, definitely an upgrade compared to kraftkit |
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
b8e8437 to
a5b1451
Compare
Contributor
Author
|
Have to rebase the code and to generate tests on Monday. |
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
2 times, most recently
from
dcaf1a6 to
c7622e6
Compare
jedevc
reviewed
May 1, 2026
jedevc
left a comment
jedevc
left a comment
Member
There was a problem hiding this comment.
Needs a rebase, and to get the tests passing 🎉
Contributor
Author
|
I'll rebase and fix afterwards |
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
3 times, most recently
from
ccbfb69 to
1aa3b6d
Compare
Contributor
Author
|
once you agree with the changes, I will fixup the I am pretty sure I covered all your requests. It now even has multi-metro support The API is now: I tested that the usual + new stuff still works |
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
1aa3b6d to
ad763de
Compare
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
ad763de to
0f148f9
Compare
jedevc
reviewed
Jun 1, 2026
Comment on lines
+215
to
+221
| // NOTE(craciunoiuc): if the same instance name appears in multiple metros | ||
| // (no metro prefix given), the last-seen result wins. Users should include | ||
| // a metro prefix to disambiguate (e.g. fra/my-instance:8080). | ||
| infoByDisplay := make(map[string]instanceInfo, len(resolved)) | ||
| for _, r := range resolved { | ||
| infoByDisplay[r.ref.Display] = r.info | ||
| } |
Member
There was a problem hiding this comment.
This is fine for now, but maybe we should have a helper CollectRefsMap or something.
Then we could use the same logic for logs.
Contributor
Author
There was a problem hiding this comment.
Ok, leaving like this. Feel free to open a linear issue and we can do in a separate PR 😳
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
0f148f9 to
33c9044
Compare
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
33c9044 to
f95426d
Compare
Allows for tunelling when inter-vm communication is enabled on the box. Requires at least 1 free instance space for the tunelling instance. Also adds support for running background tasks in tests. This enables tunelling in parallel with the curl request. Signed-off-by: Cezar Craciunoiu <[email protected]>
craciunoiuc
force-pushed
the
craciunoiuc/add-instance-tunnel
branch
from
f95426d to
d759875
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes need this option
--net-internal-traffic=vmin order to test it.The Tunlr also needs updating to remove the check for inter-vm comms.Done.
TODO: Update tests when platform is stable.Blocked on: https://github.com/unikraft-cloud/platform/pull/705Closes: TOOL-714