Replace deprecated datetime.utcnow() with timezone-aware equivalent - #3
Merged
ulikoehler merged 1 commit intoMay 4, 2026
Merged
Conversation
`datetime.datetime.utcnow()` is deprecated since Python 3.12 and
scheduled for removal in a future version:
DeprecationWarning: datetime.datetime.utcnow() is deprecated and
scheduled for removal in a future version. Use timezone-aware
objects to represent datetimes in UTC:
datetime.datetime.now(datetime.UTC).
`datetime_to_datestamp()` in `oaipmh/datestamp.py` asserts that the
input has `tzinfo is None`, so we convert the timezone-aware UTC
value back to naive with `.replace(tzinfo=None)` before passing it
in. The resulting `responseDate` string in the OAI-PMH response is
unchanged.
This is the only `datetime.utcnow()` call in the codebase; after
this change, pyoai no longer emits `DeprecationWarning` for it on
Python 3.12+.
Collaborator
Author
|
Sup @ulikoehler long time no see, I'm bringing some updates to this package thanks to the power of LLM / AI, stay tuned. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datetime.datetime.utcnow()is deprecated since Python 3.12 and scheduled for removal in a future version:datetime_to_datestamp()inoaipmh/datestamp.pyasserts that the input hastzinfo is None, so we convert the timezone-aware UTC value back to naive with.replace(tzinfo=None)before passing it in. The resultingresponseDatestring in the OAI-PMH response is unchanged.This is the only
datetime.utcnow()call in the codebase; after this change, pyoai no longer emitsDeprecationWarningfor it on Python 3.12+.