fixup rsync invocation#12
Open
yarikoptic wants to merge 1 commit into
Open
Conversation
=== Do not change lines below ===
{
"chain": [],
"cmd": "git-sedi 'rsync --avz' 'rsync -avz'",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the rsync command flags from --avzp to -avzp in cellBrowser.js. The reviewer suggests further optimizing the rsync flags to -av by removing -z (since the datasets are already compressed, avoiding unnecessary CPU usage) and -p (which is redundant as it is already included in -a).
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| htmls.push("<p><b>To bulk download all datasets in this collection via rsync:</b><br>"); | ||
| htmls.push("<code style='display:inline-block; background:#f4f4f4; border:1px solid #ddd; padding:4px 8px; border-radius:3px; font-size:12px; user-select:all'>"); | ||
| htmls.push("rsync --avzp hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); | ||
| htmls.push("rsync -avzp hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); |
There was a problem hiding this comment.
The rsync flags can be optimized for better efficiency and simplicity:
- Remove
-z(compression): The dataset files (such asexprMatrix.tsv.gzand coordinate binaries) are already compressed (gzipped). Enabling rsync compression (-z) on already compressed files wastes CPU cycles on both the client and the UCSC download server without providing any additional bandwidth savings, and can actually slow down the transfer. - Remove
-p(preserve permissions): The-a(archive) option already includes-p(preserve permissions), making the explicit-pflag redundant.
Using rsync -av is cleaner and more efficient.
Suggested change
| htmls.push("rsync -avzp hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); | |
| htmls.push("rsync -av hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); |
| htmls.push("<p><b>Bulk download via rsync:</b><br>"); | ||
| htmls.push("<code style='display:inline-block; background:#f4f4f4; border:1px solid #ddd; padding:4px 8px; border-radius:3px; font-size:12px; user-select:all'>"); | ||
| htmls.push("rsync --avzp hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); | ||
| htmls.push("rsync -avzp hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); |
There was a problem hiding this comment.
The rsync flags can be optimized for better efficiency and simplicity:
- Remove
-z(compression): The dataset files (such asexprMatrix.tsv.gzand coordinate binaries) are already compressed (gzipped). Enabling rsync compression (-z) on already compressed files wastes CPU cycles on both the client and the UCSC download server without providing any additional bandwidth savings, and can actually slow down the transfer. - Remove
-p(preserve permissions): The-a(archive) option already includes-p(preserve permissions), making the explicit-pflag redundant.
Using rsync -av is cleaner and more efficient.
Suggested change
| htmls.push("rsync -avzp hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); | |
| htmls.push("rsync -av hgdownload.gi.ucsc.edu::cells/"+datasetInfo.name+"/ ./"+datasetInfo.name+"/"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.