Fix panic when trying to print a nil Stringer#284
Merged
Conversation
This fixes an issue where we're trying to print the value of a nil Stringer which causes a panic instead of failing the test, hurting the debuggability of the failure. Fixes uber-go#283.
r-hang
approved these changes
Oct 3, 2025
pableeee
pushed a commit
to pableeee/implgen
that referenced
this pull request
Mar 7, 2026
This fixes an issue where we're trying to print the value of a nil Stringer which causes a panic instead of failing the test, hurting the debuggability of the failure. Fixes uber-go#283.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where we're trying to print the value of a nil Stringer which causes a panic instead of failing the test, hurting the debuggability of the failure.
Fixes #283.